Commit dd277533 authored by Vasily Averin's avatar Vasily Averin Committed by Greg Kroah-Hartman
Browse files

ext4: missing !bh check in ext4_xattr_inode_write()

commit eb6984fa upstream.

According to Ted Ts'o ext4_getblk() called in ext4_xattr_inode_write()
should not return bh = NULL

The only time that bh could be NULL, then, would be in the case of
something really going wrong; a programming error elsewhere (perhaps a
wild pointer dereference) or I/O error causing on-disk file system
corruption (although that would be highly unlikely given that we had
*just* allocated the blocks and so the metadata blocks in question
probably would still be in the cache).

Fixes: e50e5129

 ("ext4: xattr-in-inode support")
Signed-off-by: default avatarVasily Averin <>
Signed-off-by: default avatarTheodore Ts'o <>
Cc: # 4.13
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 4e7e558e
......@@ -1387,6 +1387,12 @@ static int ext4_xattr_inode_write(handle_t *handle, struct inode *ea_inode,
bh = ext4_getblk(handle, ea_inode, block, 0);
if (IS_ERR(bh))
return PTR_ERR(bh);
if (!bh) {
"ext4_getblk() return bh = NULL");
ret = ext4_journal_get_write_access(handle, bh);
if (ret)
goto out;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment