Commit e8bc8f9a authored by Christophe Jaillet's avatar Christophe Jaillet Committed by David S. Miller
Browse files

sctp: Remove some redundant code

In commit 311b2177

 ("sctp: simplify sk_receive_queue locking"), a call
to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
hidden in 'sctp_skb_list_tail()'

Now, the code around it looks redundant. The '_init()' part of
'skb_queue_splice_tail_init()' should already do the same.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 95357907
...@@ -140,11 +140,8 @@ int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc) ...@@ -140,11 +140,8 @@ int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc)
* we can go ahead and clear out the lobby in one shot * we can go ahead and clear out the lobby in one shot
*/ */
if (!skb_queue_empty(&sp->pd_lobby)) { if (!skb_queue_empty(&sp->pd_lobby)) {
struct list_head *list;
skb_queue_splice_tail_init(&sp->pd_lobby, skb_queue_splice_tail_init(&sp->pd_lobby,
&sk->sk_receive_queue); &sk->sk_receive_queue);
list = (struct list_head *)&sctp_sk(sk)->pd_lobby;
INIT_LIST_HEAD(list);
return 1; return 1;
} }
} else { } else {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment