Commit eb94737d authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

l2tp: constify net_device_ops structures

Check for net_device_ops structures that are only stored in the netdev_ops
field of a net_device structure.  This field is declared const, so
net_device_ops structures that have this property can be declared as const

The semantic patch that makes this change is as follows:


// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
static struct net_device_ops i@p = { ... };

identifier r.i;
struct net_device e;
position p;
e.netdev_ops = &i@p;

position p != {r.p,ok.p};
identifier r.i;
struct net_device_ops e;

@depends on !bad disable optional_qualifier@
identifier r.i;
 struct net_device_ops i = { ... };
// </smpl>

The result of size on this file before the change is:
   text	      data     bss     dec         hex	  filename
   3401        931      44    4376        1118	net/l2tp/l2tp_eth.o

and after the change it is:
   text	     data        bss	    dec	    hex	filename
   3993       347         44       4384    1120	net/l2tp/l2tp_eth.o
Signed-off-by: default avatarJulia Lawall <>
Signed-off-by: default avatarDavid S. Miller <>
parent 37307504
......@@ -121,7 +121,7 @@ static struct rtnl_link_stats64 *l2tp_eth_get_stats64(struct net_device *dev,
static struct net_device_ops l2tp_eth_netdev_ops = {
static const struct net_device_ops l2tp_eth_netdev_ops = {
.ndo_init = l2tp_eth_dev_init,
.ndo_uninit = l2tp_eth_dev_uninit,
.ndo_start_xmit = l2tp_eth_dev_xmit,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment