Commit f4e8ab7c authored by Bernard Blackham's avatar Bernard Blackham Committed by David S. Miller
Browse files

smsc95xx: generate random MAC address once, not every ifup



The smsc95xx driver currently generates a new random MAC address
every time the interface is brought up. This makes it impossible to
override using the standard `ifconfig hw ether` approach.

Past patches tried to make the MAC address a module parameter or
base it off the die ID, but it seems to me much simpler (and
hopefully less controversial) to stick with the current random
generation scheme, but allow the user to change the address.

This patch does exactly that - it moves the random address
generation from smsc95xx_reset() into smsc95xx_bind(), so that it is
done once on module load, not on every ifup. The user can then
override this using the standard mechanisms.

Applies against 2.6.35 and linux-2.6 head.
Signed-off-by: default avatarBernard Blackham <b-omap@largestprime.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fdb246f5
......@@ -805,8 +805,6 @@ static int smsc95xx_reset(struct usbnet *dev)
return ret;
}
smsc95xx_init_mac_address(dev);
ret = smsc95xx_set_mac_address(dev);
if (ret < 0)
return ret;
......@@ -1047,6 +1045,8 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf)
pdata->use_tx_csum = DEFAULT_TX_CSUM_ENABLE;
pdata->use_rx_csum = DEFAULT_RX_CSUM_ENABLE;
smsc95xx_init_mac_address(dev);
/* Init all registers */
ret = smsc95xx_reset(dev);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment