Commit ff4a88bf authored by Heinz Mauelshagen's avatar Heinz Mauelshagen Committed by Mike Snitzer
Browse files

dm raid: avoid superfluous memory barriers on static metadata


Signed-off-by: default avatarHeinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 7193a9de
......@@ -366,14 +366,12 @@ static bool rs_is_reshapable(struct raid_set *rs)
/* Return true, if raid set in @rs is recovering */
static bool rs_is_recovering(struct raid_set *rs)
{
smp_rmb();
return rs->md.recovery_cp != MaxSector;
}
/* Return true, if raid set in @rs is reshaping */
static bool rs_is_reshaping(struct raid_set *rs)
{
smp_rmb();
return rs->md.reshape_position != MaxSector;
}
......@@ -1484,7 +1482,6 @@ static int rs_check_takeover(struct raid_set *rs)
struct mddev *mddev = &rs->md;
unsigned int near_copies;
smp_rmb();
if (rs->md.degraded) {
rs->ti->error = "Can't takeover degraded raid set";
return -EPERM;
......@@ -1758,8 +1755,6 @@ static int rs_check_reshape(struct raid_set *rs)
{
struct mddev *mddev = &rs->md;
smp_rmb(); /* Make sure we access recent reshape position */
if (!mddev->pers || !mddev->pers->check_reshape)
rs->ti->error = "Reshape not supported";
else if (mddev->degraded)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment