1. 17 Dec, 2018 2 commits
  2. 13 Dec, 2018 4 commits
  3. 08 Dec, 2018 1 commit
    • Arnd Bergmann's avatar
      staging: rts5208: fix gcc-8 logic error warning · 46762a64
      Arnd Bergmann authored
      commit 58930cce
      
       upstream.
      
      As gcc-8 points out, the bit mask check makes no sense here:
      
      drivers/staging/rts5208/sd.c: In function 'ext_sd_send_cmd_get_rsp':
      drivers/staging/rts5208/sd.c:4130:25: error: bitwise comparison always evaluates to true [-Werror=tautological-compare]
      
      However, the code is even more bogus, as we have already
      checked for the SD_RSP_TYPE_R0 case earlier in the function
      and returned success. As seen in the mmc/sd driver core,
      SD_RSP_TYPE_R0 means "no response" anyway, so checking for
      a particular response would not help either.
      
      This just removes the nonsensical code to get rid of the
      warning.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      46762a64
  4. 05 Dec, 2018 2 commits
    • Larry Finger's avatar
      staging: rtl8723bs: Add missing return for cfg80211_rtw_get_station · 74abe400
      Larry Finger authored
      commit 8561fb31
      
       upstream.
      
      With Androidx86 8.1, wificond returns "failed to get
      nl80211_sta_info_tx_failed" and wificondControl returns "Invalid signal
      poll result from wificond". The fix is to OR sinfo->filled with
      BIT_ULL(NL80211_STA_INFO_TX_FAILED).
      
      This missing bit is apparently not needed with NetworkManager, but it
      does no harm in that case.
      Reported-and-Tested-by: default avataryouling257 <youling257@gmail.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: youling257 <youling257@gmail.com>
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      74abe400
    • Ben Wolsieffer's avatar
      staging: vchiq_arm: fix compat VCHIQ_IOC_AWAIT_COMPLETION · ca0908dd
      Ben Wolsieffer authored
      commit 5a96b2d3 upstream.
      
      The compatibility ioctl wrapper for VCHIQ_IOC_AWAIT_COMPLETION assumes that
      the native ioctl always uses a message buffer and decrements msgbufcount.
      Certain message types do not use a message buffer and in this case
      msgbufcount is not decremented, and completion->header for the message is
      NULL. Because the wrapper unconditionally decrements msgbufcount, the
      calling process may assume that a message buffer has been used even when
      it has not.
      
      This results in a memory leak in the userspace code that interfaces with
      this driver. When msgbufcount is decremented, the userspace code assumes
      that the buffer can be freed though the reference in completion->header,
      which cannot happen when the reference is NULL.
      
      This patch causes the wrapper to only decrement msgbufcount when the
      native ioctl decrements it. Note that we cannot simply copy the native
      ioctl's value of msgbufcount, because the wrapper only retrieves messages
      from the native ioctl one at a time, while userspace may request multiple
      messages.
      
      See https://github.com/raspberrypi/linux/pull/2703 for more discussion of
      this patch.
      
      Fixes: 5569a126
      
       ("staging: vchiq_arm: Add compatibility wrappers for ioctls")
      Signed-off-by: default avatarBen Wolsieffer <benwolsieffer@gmail.com>
      Acked-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      ca0908dd
  5. 21 Nov, 2018 1 commit
  6. 20 Oct, 2018 1 commit
  7. 04 Oct, 2018 3 commits
  8. 26 Sep, 2018 3 commits
  9. 15 Sep, 2018 3 commits
  10. 05 Sep, 2018 1 commit
    • Guenter Roeck's avatar
      media: staging: omap4iss: Include asm/cacheflush.h after generic includes · 1875957f
      Guenter Roeck authored
      [ Upstream commit 0894da84 ]
      
      Including asm/cacheflush.h first results in the following build error
      when trying to build sparc32:allmodconfig, because 'struct page' has not
      been declared, and the function declaration ends up creating a separate
      (private) declaration of struct page (as a result of function arguments
      being in the scope of the function declaration and definition, not in
      global scope).
      
      The C scoping rules do not just affect variable visibility, they also
      affect type declaration visibility.
      
      The end result is that when the actual call site is seen in
      <linux/highmem.h>, the 'struct page' type in the caller is not the same
      'struct page' that the function was declared with, resulting in:
      
        In file included from arch/sparc/include/asm/page.h:10:0,
                         ...
                         from drivers/staging/media/omap4iss/iss_video.c:15:
        include/linux/highmem.h: In function 'clear_user_highpage':
        include/linux/highmem.h:137:31: error:
      	passing argument 1 of 'sparc_flush_page_to_ram' from incompatible
      	pointer type
      
      Include generic includes files first to fix the problem.
      
      Fixes: fc96d58c
      
       ("[media] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices")
      Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Cc: Randy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      [ Added explanation of C scope rules - Linus ]
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1875957f
  11. 24 Aug, 2018 1 commit
  12. 03 Aug, 2018 7 commits
    • Mauro Carvalho Chehab's avatar
      media: atomisp: compat32: fix __user annotations · 98121d66
      Mauro Carvalho Chehab authored
      [ Upstream commit ad4222a0
      
       ]
      
      The __user annotations at the compat32 code is not right:
      
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:81:18: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:81:18:    expected void *base
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:81:18:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:232:23: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:232:23:    expected unsigned int [usertype] *xcoords_y
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:232:23:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:233:23: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:233:23:    expected unsigned int [usertype] *ycoords_y
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:233:23:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:234:24: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:234:24:    expected unsigned int [usertype] *xcoords_uv
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:234:24:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:235:24: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:235:24:    expected unsigned int [usertype] *ycoords_uv
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:235:24:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:296:29: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:296:29:    expected unsigned int [usertype] *effective_width
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:296:29:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:360:29: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:360:29:    expected unsigned int [usertype] *effective_width
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:360:29:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:437:19: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:437:19:    expected struct v4l2_framebuffer *frame
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:437:19:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:481:29: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:481:29:    expected unsigned short *calb_grp_values
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:481:29:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:701:39: warning: cast removes address space of expression
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:704:21: warning: incorrect type in argument 1 (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:704:21:    expected void const volatile [noderef] <asn:1>*<noident>
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:704:21:    got unsigned int [usertype] *src
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:737:43: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:737:43:    expected struct atomisp_shading_table *shading_table
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:737:43:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:742:44: warning: incorrect type in argument 1 (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:742:44:    expected void [noderef] <asn:1>*to
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:742:44:    got struct atomisp_shading_table *shading_table
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:755:41: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:755:41:    expected struct atomisp_morph_table *morph_table
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:755:41:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:760:44: warning: incorrect type in argument 1 (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:760:44:    expected void [noderef] <asn:1>*to
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:760:44:    got struct atomisp_morph_table *morph_table
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:772:40: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:772:40:    expected struct atomisp_dvs2_coefficients *dvs2_coefs
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:772:40:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:777:44: warning: incorrect type in argument 1 (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:777:44:    expected void [noderef] <asn:1>*to
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:777:44:    got struct atomisp_dvs2_coefficients *dvs2_coefs
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:788:46: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:788:46:    expected struct atomisp_dvs_6axis_config *dvs_6axis_config
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:788:46:    got void [noderef] <asn:1>*
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:793:44: warning: incorrect type in argument 1 (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:793:44:    expected void [noderef] <asn:1>*to
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:793:44:    got struct atomisp_dvs_6axis_config *dvs_6axis_config
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:853:17: warning: incorrect type in assignment (different address spaces)
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:853:17:    expected struct atomisp_sensor_ae_bracketing_lut_entry *lut
         drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:853:17:    got void [noderef] <asn:1>*
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      98121d66
    • NeilBrown's avatar
      staging: lustre: ldlm: free resource when ldlm_lock_create() fails. · 41e1f1fe
      NeilBrown authored
      [ Upstream commit d8caf662
      
       ]
      
      ldlm_lock_create() gets a resource, but don't put it on
      all failure paths. It should.
      Signed-off-by: default avatarNeilBrown <neilb@suse.com>
      Reviewed-by: default avatarJames Simmons <jsimmons@infradead.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      41e1f1fe
    • James Simmons's avatar
      staging: lustre: llite: correct removexattr detection · e906355a
      James Simmons authored
      [ Upstream commit 1b60f6df
      
       ]
      
      In ll_xattr_set_common() detect the removexattr() case correctly by
      testing for a NULL value as well as XATTR_REPLACE.
      Signed-off-by: default avatarJohn L. Hammond <john.hammond@intel.com>
      Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10787
      Reviewed-on: https://review.whamcloud.com/
      
      Reviewed-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
      Reviewed-by: default avatarJames Simmons <uja.ornl@yahoo.com>
      Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      e906355a
    • Stefan Wahren's avatar
      staging: vchiq_core: Fix missing semaphore release in error case · fea5a0d8
      Stefan Wahren authored
      [ Upstream commit 8113b89f ]
      
      The bail out branch in case of a invalid tx_pos missed a semaphore
      release. Dan Carpenter found this with a static checker.
      
      Fixes: d1eab9de
      
       ("staging: vchiq_core: Bail out in case of invalid tx_pos")
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      fea5a0d8
    • Doug Oucharek's avatar
      staging: lustre: o2iblnd: Fix FastReg map/unmap for MLX5 · 66eb9942
      Doug Oucharek authored
      [ Upstream commit 24d4b7c8
      
       ]
      
      The FastReg support in ko2iblnd was not unmapping pool items
      causing the items to leak.  In addition, the mapping code
      is not growing the pool like we do with FMR.
      
      This patch makes sure we are unmapping FastReg pool elements
      when we are done with them.  It also makes sure the pool
      will grow when we depleat the pool.
      Signed-off-by: default avatarDoug Oucharek <doug.s.oucharek@intel.com>
      Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9472
      Reviewed-on: https://review.whamcloud.com/27015
      
      Reviewed-by: default avatarAndrew Perepechko <andrew.perepechko@seagate.com>
      Reviewed-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
      Reviewed-by: default avatarJames Simmons <uja.ornl@yahoo.com>
      Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
      Signed-off-by: default avatarDoug Oucharek <dougso@me.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      66eb9942
    • Doug Oucahrek's avatar
      staging: lustre: o2iblnd: fix race at kiblnd_connect_peer · 52a21fca
      Doug Oucahrek authored
      [ Upstream commit cf04968e
      
       ]
      
      cmid will be destroyed at OFED if kiblnd_cm_callback return error.
      if error happen before the end of kiblnd_connect_peer, it will touch
      destroyed cmid and fail as
      (o2iblnd_cb.c:1315:kiblnd_connect_peer())
                  ASSERTION( cmid->device != ((void *)0) ) failed:
      Signed-off-by: default avatarAlexander Boyko <alexander.boyko@seagate.com>
      Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10015
      
      Reviewed-by: default avatarAlexey Lyashkov <c17817@cray.com>
      Reviewed-by: default avatarDoug Oucharek <dougso@me.com>
      Reviewed-by: default avatarJohn L. Hammond <john.hammond@intel.com>
      Signed-off-by: default avatarDoug Oucharek <dougso@me.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      52a21fca
    • Mauro Carvalho Chehab's avatar
      media: atomisp: ov2680: don't declare unused vars · 62a87c87
      Mauro Carvalho Chehab authored
      [ Upstream commit e5c0680f
      
       ]
      
      drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: In function ‘__ov2680_set_exposure’:
      drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:400:10: warning: variable ‘hts’ set but not used [-Wunused-but-set-variable]
        u16 vts,hts;
                ^~~
      drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: In function ‘ov2680_detect’:
      drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:1164:5: warning: variable ‘revision’ set but not used [-Wunused-but-set-variable]
        u8 revision;
           ^~~~~~~~
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      62a87c87
  13. 28 Jul, 2018 1 commit
  14. 17 Jul, 2018 2 commits
  15. 11 Jul, 2018 1 commit
  16. 08 Jul, 2018 1 commit
  17. 16 Jun, 2018 1 commit
  18. 25 May, 2018 5 commits