1. 23 Nov, 2016 2 commits
  2. 29 Jan, 2016 1 commit
  3. 17 Oct, 2015 1 commit
  4. 15 Aug, 2015 1 commit
  5. 20 Mar, 2015 1 commit
  6. 11 Sep, 2014 1 commit
  7. 23 May, 2014 1 commit
  8. 14 May, 2014 1 commit
  9. 01 Apr, 2014 1 commit
    • Rusty Russell's avatar
      staging: fix up speakup kobject mode · 22c9bcad
      Rusty Russell authored
      
      
      It uses the unnecessary S_IFREG bit which broke when my
      stricter-checking-for-mode patch went in.
      
      Since we're fixing it anyway, the extra level of indirection is
      confusing for readers (ROOT_W == rw-r--r-- for example).
      
      Also, many of these are other-writable.  Is that really intended?
      
      I'll-queue-this-patch-up-in-a-bit-by: Greg KH <greg@kroah.com>
      Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
      22c9bcad
  10. 22 May, 2013 1 commit
    • Emil Goode's avatar
      staging: speakup: fix warnings by adding __user annotations · 7c10f1cd
      Emil Goode authored
      
      
      This patch fixes the following sparse warnings by adding
      __user annotations.
      
      drivers/staging/speakup/speakup_soft.c:248:34: warning:
              incorrect type in argument 1 (different address spaces)
              drivers/staging/speakup/speakup_soft.c:248:34:
              expected void [noderef] <asn:1>*dst
              drivers/staging/speakup/speakup_soft.c:248:34:
              got char *[assigned] cp
      drivers/staging/speakup/speakup_soft.c:272:40: warning:
              incorrect type in argument 1 (different address spaces)
              drivers/staging/speakup/speakup_soft.c:272:40:
              expected char const [noderef] <asn:1>*s
              drivers/staging/speakup/speakup_soft.c:272:40:
              got char const *buf
      drivers/staging/speakup/speakup_soft.c:306:17: warning:
              incorrect type in initializer (incompatible argument 2
              (different address spaces))
              drivers/staging/speakup/speakup_soft.c:306:17:
              expected long ( *read )( ... )
              drivers/staging/speakup/speakup_soft.c:306:17:
              got long ( static [toplevel] *<noident> )( ... )
      drivers/staging/speakup/speakup_soft.c:307:18: warning:
              incorrect type in initializer (incompatible argument 2
              (different address spaces))
              drivers/staging/speakup/speakup_soft.c:307:18:
              expected long ( *write )( ... )
              drivers/staging/speakup/speakup_soft.c:307:18:
              got long ( static [toplevel] *<nfile_operationsoident> )( ... )
      
      drivers/staging/speakup/devsynth.c:29:41: warning:
              incorrect type in argument 2 (different address spaces)
              drivers/staging/speakup/devsynth.c:29:41:
              expected void const [noderef] <asn:1>*from
              drivers/staging/speakup/devsynth.c:29:41:    got char const *ptr
      drivers/staging/speakup/devsynth.c:62:17: warning:
              incorrect type in initializer (incompatible argument 2
              (different address spaces))
              drivers/staging/speakup/devsynth.c:62:17:
              expected long ( *read )( ... )
              drivers/staging/speakup/devsynth.c:62:17:
              got long ( static [toplevel] *<noident> )( ... )
      drivers/staging/speakup/devsynth.c:63:18: warning:
              incorrect type in initializer (incompatible argument 2
              (different address spaces))
              drivers/staging/speakup/devsynth.c:63:18:
              expected long ( *write )( ... )
              drivers/staging/speakup/devsynth.c:63:18:
              got long ( static [toplevel] *<noident> )( ... )
      Signed-off-by: default avatarEmil Goode <emilgoode@gmail.com>
      Acked-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7c10f1cd
  11. 16 May, 2013 1 commit
  12. 17 Sep, 2012 1 commit
    • Ben Hutchings's avatar
      staging: speakup_soft: Fix reading of init string · 40fe4f89
      Ben Hutchings authored
      
      
      softsynth_read() reads a character at a time from the init string;
      when it finds the null terminator it sets the initialized flag but
      then repeats the last character.
      
      Additionally, if the read() buffer is not big enough for the init
      string, the next read() will start reading from the beginning again.
      So the caller may never progress to reading anything else.
      
      Replace the simple initialized flag with the current position in
      the init string, carried over between calls.  Switch to reading
      real data once this reaches the null terminator.
      
      (This assumes that the length of the init string can't change, which
      seems to be the case.  Really, the string and position belong together
      in a per-file private struct.)
      Tested-by: default avatarSamuel Thibault <sthibault@debian.org>
      Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      40fe4f89
  13. 04 Sep, 2012 1 commit
  14. 28 Jun, 2011 1 commit
  15. 15 Oct, 2010 1 commit
  16. 08 Oct, 2010 1 commit