1. 21 Oct, 2010 1 commit
  2. 30 Aug, 2010 1 commit
  3. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  4. 17 Feb, 2010 1 commit
  5. 16 Feb, 2010 1 commit
  6. 28 Jan, 2010 2 commits
  7. 24 Oct, 2009 1 commit
  8. 23 Jun, 2009 1 commit
  9. 15 Dec, 2008 1 commit
  10. 25 Mar, 2008 1 commit
  11. 01 Feb, 2008 1 commit
  12. 18 Oct, 2007 2 commits
  13. 10 Oct, 2007 3 commits
    • Herbert Xu's avatar
      [IPSEC]: Move IP length/checksum setting out of transforms · ceb1eec8
      Herbert Xu authored
      
      
      This patch moves the setting of the IP length and checksum fields out of
      the transforms and into the xfrmX_output functions.  This would help future
      efforts in merging the transforms themselves.
      
      It also adds an optimisation to ipcomp due to the fact that the transport
      offset is guaranteed to be zero.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ceb1eec8
    • Herbert Xu's avatar
      [IPSEC]: Set skb->data to payload in x->mode->output · 7b277b1a
      Herbert Xu authored
      
      
      This patch changes the calling convention so that on entry from
      x->mode->output and before entry into x->type->output skb->data
      will point to the payload instead of the IP header.
      
      This is essentially a redistribution of skb_push/skb_pull calls
      with the aim of minimising them on the common path of tunnel +
      ESP.
      
      It'll also let us use the same calling convention between IPv4
      and IPv6 with the next patch.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7b277b1a
    • Herbert Xu's avatar
      [IPSEC]: Store IPv6 nh pointer in mac_header on output · 007f0211
      Herbert Xu authored
      
      
      Current the x->mode->output functions store the IPv6 nh pointer in the
      skb network header.  This is inconvenient because the network header then
      has to be fixed up before the packet can leave the IPsec stack.  The mac
      header field is unused on output so we can use that to store this instead.
      
      This patch does that and removes the network header fix-up in xfrm_output.
      
      It also uses ipv6_hdr where appropriate in the x->type->output functions.
      
      There is also a minor clean-up in esp4 to make it use the same code as
      esp6 to help any subsequent effort to merge the two.
      
      Lastly it kills two redundant skb_set_* statements in BEET that were
      simply copied over from transport mode.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      007f0211
  14. 20 Jul, 2007 1 commit
    • Paul Mundt's avatar
      mm: Remove slab destructors from kmem_cache_create(). · 20c2df83
      Paul Mundt authored
      Slab destructors were no longer supported after Christoph's
      c59def9f
      
       change. They've been
      BUGs for both slab and slub, and slob never supported them
      either.
      
      This rips out support for the dtor pointer from kmem_cache_create()
      completely and fixes up every single callsite in the kernel (there were
      about 224, not including the slab allocator definitions themselves,
      or the documentation references).
      Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
      20c2df83
  15. 11 Jul, 2007 1 commit
  16. 29 Apr, 2007 1 commit
  17. 26 Apr, 2007 1 commit
  18. 22 Mar, 2007 1 commit
  19. 13 Feb, 2007 1 commit
  20. 11 Feb, 2007 1 commit
  21. 07 Dec, 2006 2 commits
  22. 03 Dec, 2006 2 commits
  23. 01 Nov, 2006 1 commit
  24. 29 Sep, 2006 1 commit
  25. 22 Sep, 2006 1 commit
  26. 24 Jul, 2006 1 commit
    • David S. Miller's avatar
      [IPV6] xfrm6_tunnel: Delete debugging code. · a922ba55
      David S. Miller authored
      
      
      It doesn't compile, and it's dubious in several regards:
      
      1) is enabled by non-Kconfig controlled CONFIG_* value
         (noted by Randy Dunlap)
      2) XFRM6_TUNNEL_SPI_MAGIC is defined after it's first use
      3) the debugging messages print object pointer addresses
         which have no meaning without context
      
      So let's just get rid of it.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a922ba55
  27. 30 Jun, 2006 1 commit
  28. 01 Apr, 2006 1 commit
    • Herbert Xu's avatar
      [IPSEC]: Kill unused decap state argument · e695633e
      Herbert Xu authored
      
      
      This patch removes the decap_state argument from the xfrm input hook.
      Previously this function allowed the input hook to share state with
      the post_input hook.  The latter has since been removed.
      
      The only purpose for it now is to check the encap type.  However, it
      is easier and better to move the encap type check to the generic
      xfrm_rcv function.  This allows us to get rid of the decap state
      argument altogether.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e695633e
  29. 29 Mar, 2006 1 commit
    • Herbert Xu's avatar
      [INET]: Introduce tunnel4/tunnel6 · d2acc347
      Herbert Xu authored
      
      
      Basically this patch moves the generic tunnel protocol stuff out of
      xfrm4_tunnel/xfrm6_tunnel and moves it into the new files of tunnel4.c
      and tunnel6 respectively.
      
      The reason for this is that the problem that Hugo uncovered is only
      the tip of the iceberg.  The real problem is that when we removed the
      dependency of ipip on xfrm4_tunnel we didn't really consider the module
      case at all.
      
      For instance, as it is it's possible to build both ipip and xfrm4_tunnel
      as modules and if the latter is loaded then ipip simply won't load.
      
      After considering the alternatives I've decided that the best way out of
      this is to restore the dependency of ipip on the non-xfrm-specific part
      of xfrm4_tunnel.  This is acceptable IMHO because the intention of the
      removal was really to be able to use ipip without the xfrm subsystem.
      This is still preserved by this patch.
      
      So now both ipip/xfrm4_tunnel depend on the new tunnel4.c which handles
      the arbitration between the two.  The order of processing is determined
      by a simple integer which ensures that ipip gets processed before
      xfrm4_tunnel.
      
      The situation for ICMP handling is a little bit more complicated since
      we may not have enough information to determine who it's for.  It's not
      a big deal at the moment since the xfrm ICMP handlers are basically
      no-ops.  In future we can deal with this when we look at ICMP caching
      in general.
      
      The user-visible change to this is the removal of the TUNNEL Kconfig
      prompts.  This makes sense because it can only be used through IPCOMP
      as it stands.
      
      The addition of the new modules shouldn't introduce any problems since
      module dependency will cause them to be loaded.
      
      Oh and I also turned some unnecessary pskb's in IPv6 related to this
      patch to skb's.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d2acc347
  30. 21 Mar, 2006 1 commit
  31. 13 Jan, 2006 1 commit
    • Joe Perches's avatar
      [NET]: Use NIP6_FMT in kernel.h · 46b86a2d
      Joe Perches authored
      
      
      There are errors and inconsistency in the display of NIP6 strings.
      	ie: net/ipv6/ip6_flowlabel.c
      
      There are errors and inconsistency in the display of NIPQUAD strings too.
      	ie: net/netfilter/nf_conntrack_ftp.c
      
      This patch:
      	adds NIP6_FMT to kernel.h
      	changes all code to use NIP6_FMT
      	fixes net/ipv6/ip6_flowlabel.c
      	adds NIPQUAD_FMT to kernel.h
      	fixes net/netfilter/nf_conntrack_ftp.c
      	changes a few uses of "%u.%u.%u.%u" to NIPQUAD_FMT for symmetry to NIP6_FMT
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      46b86a2d
  32. 07 Jan, 2006 1 commit
  33. 29 Aug, 2005 1 commit
  34. 20 Jun, 2005 1 commit