1. 13 Jan, 2011 3 commits
    • Hans Schillstrom's avatar
      IPVS: netns, use ip_vs_proto_data as param. · 9330419d
      Hans Schillstrom authored
      
      
      ip_vs_protocol *pp is replaced by ip_vs_proto_data *pd in
      function call in ip_vs_protocol struct i.e. :,
       - timeout_change()
       - state_transition()
      
      ip_vs_protocol_timeout_change() got ipvs as param, due to above
      and a upcoming patch - defence work
      
      Most of this changes are triggered by Julians comment:
      "tcp_timeout_change should work with the new struct ip_vs_proto_data
              so that tcp_state_table will go to pd->state_table
              and set_tcp_state will get pd instead of pp"
      
      *v3
      Mostly comments from Julian
      The pp -> pd conversion should start from functions like
      ip_vs_out() that use pp = ip_vs_proto_get(iph.protocol),
      now they should use ip_vs_proto_data_get(net, iph.protocol).
      conn_in_get() and conn_out_get() unused param *pp, removed.
      
      *v4
      ip_vs_protocol_timeout_change() walk the proto_data path.
      Signed-off-by: default avatarHans Schillstrom <hans.schillstrom@ericsson.com>
      Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
      Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
      9330419d
    • Hans Schillstrom's avatar
      IPVS: netns preparation for proto_sctp · 9d934878
      Hans Schillstrom authored
      
      
      In this phase (one), all local vars will be moved to ipvs struct.
      
      Remaining work, add param struct net *net to a couple of
      functions that is common for all protos and use ip_vs_proto_data
      
      *v3
       Removed unuset function set_state_timeout()
      Signed-off-by: default avatarHans Schillstrom <hans.schillstrom@ericsson.com>
      Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
      Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
      9d934878
    • Hans Schillstrom's avatar
      IPVS: netns to services part 1 · fc723250
      Hans Schillstrom authored
      
      
      Services hash tables got netns ptr a hash arg,
      While Real Servers (rs) has been moved to ipvs struct.
      Two new inline functions added to get net ptr from skb.
      
      Since ip_vs is called from different contexts there is two
      places to dig for the net ptr skb->dev or skb->sk
      this is handled in skb_net() and skb_sknet()
      
      Global functions, ip_vs_service_get() ip_vs_lookup_real_service()
      etc have got  struct net *net as first param.
      If possible get net ptr skb etc,
       - if not &init_net is used at this early stage of patching.
      
      ip_vs_ctl.c  procfs not ready for netns yet.
      
      *v3
       Comments by Julian
      - __ip_vs_service_find and __ip_vs_svc_fwm_find are fast path,
        net_eq(svc->net, net) so the check is at the end now.
      - net = skb_net(skb) in ip_vs_out moved after check for skb_dst.
      Signed-off-by: default avatarHans Schillstrom <hans.schillstrom@ericsson.com>
      Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
      Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
      fc723250
  2. 25 Nov, 2010 1 commit
    • Hans Schillstrom's avatar
      IPVS: Handle Scheduling errors. · a5959d53
      Hans Schillstrom authored
      
      
      If ip_vs_conn_fill_param_persist return an error to ip_vs_sched_persist,
      this error must propagate as ignored=-1 to ip_vs_schedule().
      Errors from ip_vs_conn_new() in ip_vs_sched_persist() and ip_vs_schedule()
      should also return *ignored=-1;
      
      This patch just relies on the fact that ignored is 1 before calling
      ip_vs_sched_persist().
      
      Sent from Julian:
        "The new case when ip_vs_conn_fill_param_persist fails
         should set *ignored = -1, so that we can use NF_DROP,
         see below. *ignored = -1 should be also used for ip_vs_conn_new
         failure in ip_vs_sched_persist() and ip_vs_schedule().
         The new negative value should be handled in tcp,udp,sctp"
      
      "To summarize:
      
      - *ignored = 1:
            protocol tried to schedule (eg. on SYN), found svc but the
            svc/scheduler decides that this packet should be accepted with
            NF_ACCEPT because it must not be scheduled.
      
      - *ignored = 0:
            scheduler can not find destination, so try bypass or
            return ICMP and then NF_DROP (ip_vs_leave).
      
      - *ignored = -1:
            scheduler tried to schedule but fatal error occurred, eg.
            ip_vs_conn_new failure (ENOMEM) or ip_vs_sip_fill_param
            failure such as missing Call-ID, ENOMEM on skb_linearize
            or pe_data. In this case we should return NF_DROP without
            any attempts to send ICMP with ip_vs_leave."
      
      More or less all ideas and input to this patch is work from
      Julian Anastasov
      Signed-off-by: default avatarHans Schillstrom <hans.schillstrom@ericsson.com>
      Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
      Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
      a5959d53
  3. 21 Oct, 2010 2 commits
    • Julian Anastasov's avatar
      ipvs: provide address family for debugging · 0d79641a
      Julian Anastasov authored
      
      
       	As skb->protocol is not valid in LOCAL_OUT add
      parameter for address family in packet debugging functions.
      Even if ports are not present in AH and ESP change them to
      use ip_vs_tcpudp_debug_packet to show at least valid addresses
      as before. This patch removes the last user of skb->protocol
      in IPVS.
      Signed-off-by: default avatarJulian Anastasov <ja@ssi.bg>
      Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
      0d79641a
    • Julian Anastasov's avatar
      ipvs: do not schedule conns from real servers · 190ecd27
      Julian Anastasov authored
      
      
       	This patch is needed to avoid scheduling of
      packets from local real server when we add ip_vs_in
      in LOCAL_OUT hook to support local client.
      
       	Currently, when ip_vs_in can not find existing
      connection it tries to create new one by calling ip_vs_schedule.
      
       	The default indication from ip_vs_schedule was if
      connection was scheduled to real server. If real server is
      not available we try to use the bypass forwarding method
      or to send ICMP error. But in some cases we do not want to use
      the bypass feature. So, add flag 'ignored' to indicate if
      the scheduler ignores this packet.
      
       	Make sure we do not create new connections from replies.
      We can hit this problem for persistent services and local real
      server when ip_vs_in is added to LOCAL_OUT hook to handle
      local clients.
      
       	Also, make sure ip_vs_schedule ignores SYN packets
      for Active FTP DATA from local real server. The FTP DATA
      connection should be created on SYN+ACK from client to assign
      correct connection daddr.
      Signed-off-by: default avatarJulian Anastasov <ja@ssi.bg>
      Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
      190ecd27
  4. 05 Oct, 2010 1 commit
  5. 02 Aug, 2010 1 commit
  6. 09 Jul, 2010 1 commit
  7. 18 Feb, 2010 1 commit