1. 12 Feb, 2010 1 commit
    • Herbert Xu's avatar
      inet: Remove bogus IGMPv3 report handling · c6b471e6
      Herbert Xu authored
      
      
      Currently we treat IGMPv3 reports as if it were an IGMPv2/v1 report.
      This is broken as IGMPv3 reports are formatted differently.  So we
      end up suppressing a bogus multicast group (which should be harmless
      as long as the leading reserved field is zero).
      
      In fact, IGMPv3 does not allow membership report suppression so
      we should simply ignore IGMPv3 membership reports as a host.
      
      This patch does exactly that.  I kept the case statement for it
      so people won't accidentally add it back thinking that we overlooked
      this case.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c6b471e6
  2. 11 Feb, 2010 1 commit
    • Damian Lukowski's avatar
      tcp: fix ICMP-RTO war · 59885640
      Damian Lukowski authored
      Make sure, that TCP has a nonzero RTT estimation after three-way
      handshake. Currently, a listening TCP has a value of 0 for srtt,
      rttvar and rto right after the three-way handshake is completed
      with TCP timestamps disabled.
      This will lead to corrupt RTO recalculation and retransmission
      flood when RTO is recalculated on backoff reversion as introduced
      in "Revert RTO on ICMP destination unreachable"
      (f1ecd5d9
      
      ).
      This behaviour can be provoked by connecting to a server which
      "responds first" (like SMTP) and rejecting every packet after
      the handshake with dest-unreachable, which will lead to softirq
      load on the server (up to 30% per socket in some tests).
      
      Thanks to Ilpo Jarvinen for providing debug patches and to
      Denys Fedoryshchenko for reporting and testing.
      
      Changes since v3: Removed bad characters in patchfile.
      Reported-by: default avatarDenys Fedoryshchenko <denys@visp.net.lb>
      Signed-off-by: default avatarDamian Lukowski <damian@tvk.rwth-aachen.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      59885640
  3. 10 Feb, 2010 5 commits
  4. 09 Feb, 2010 7 commits
  5. 08 Feb, 2010 9 commits
  6. 05 Feb, 2010 1 commit
  7. 04 Feb, 2010 16 commits
    • Rafael J. Wysocki's avatar
      pktgen: Fix freezing problem · 1b3f720b
      Rafael J. Wysocki authored
      Add missing try_to_freeze() to one of the pktgen_thread_worker() code
      paths so that it doesn't block suspend/hibernation.
      
      Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006
      
      Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
      Reported-and-tested-by: default avatarCiprian Dorin Craciun <ciprian.craciun@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1b3f720b
    • Alexander Duyck's avatar
      igb: make certain to reassign legacy interrupt vectors after reset · feeb2721
      Alexander Duyck authored
      
      
      This change corrects an issue that will cause false hangs when using either
      82575 or 82580 in legacy interrupt mode.  The issue is caused when there is
      a slow traffic flow and an "ethtool -r" is executed while using legacy or
      MSI interrupts.  MSI-X is not affected by this issue due to the fact that
      we were already reconfiguring the vectors after reset.
      
      If possible it would be best to push this for net-2.6 since it is resolving
      a bug but if that is not possible then net-next-2.6 will be fine.
      Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      feeb2721
    • Thadeu Lima de Souza Cascardo's avatar
      irda: add missing BKL in irnet_ppp ioctl · 3fdde0a1
      Thadeu Lima de Souza Cascardo authored
      
      
      One ioctl has been forgotten when the BKL was push down into irnet_ppp
      ioctl function.
      Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3fdde0a1
    • Thadeu Lima de Souza Cascardo's avatar
      irda: unbalanced lock_kernel in irnet_ppp · 454debe4
      Thadeu Lima de Souza Cascardo authored
      
      
      Add the missing unlock_kernel in one ioctl operation.
      Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      454debe4
    • Krishna Kumar's avatar
      ixgbe: Fix return of invalid txq · fdd3d631
      Krishna Kumar authored
      a developer had complained of getting lots of warnings:
      
      "eth16 selects TX queue 98, but real number of TX queues is 64"
      
      http://www.mail-archive.com/e1000-devel@lists.sourceforge.net/msg02200.html
      
      
      
      As there was no follow up on that bug, I am submitting this
      patch assuming that the other return points will not return
      invalid txq's, and also that this fixes the bug (not tested).
      Signed-off-by: default avatarKrishna Kumar <krkumar2@in.ibm.com>
      Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
      Acked-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fdd3d631
    • Anton Blanchard's avatar
      ixgbe: Fix ixgbe_tx_map error path · e44d38e1
      Anton Blanchard authored
      Commit e5a43549
      
       (ixgbe: remove
      skb_dma_map/unmap calls from driver) looks to have introduced a bug in
      ixgbe_tx_map. If we get an error from a PCI DMA call, we loop backwards
      through count until it becomes -1 and return that.
      
      The caller of ixgbe_tx_map expects 0 on error, so return that instead.
      Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e44d38e1
    • Amit Kumar Salecha's avatar
      netxen: protect resource cleanup by rtnl lock · e15eec28
      Amit Kumar Salecha authored
      
      
      o context resources can be in used, while resource cleanup is in progress,
        during fw recover.
      o Null pointer execption can occur in send_cmd_desc, if fw recovery
        module frees tx ring without rtnl lock.
      o Same applies to ethtool register dump.
      Signed-off-by: default avatarAmit Kumar Salecha <amit.salecha@qlogic.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e15eec28
    • Amit Kumar Salecha's avatar
      netxen: fix tx timeout recovery for NX2031 chip · 41f3e0b1
      Amit Kumar Salecha authored
      
      
      For NX2031, first try to scrub interrupt before requesting firmware
      reset. Return statement was missing after scrubbbing interrupt.
      Signed-off-by: default avatarVernon Mauery <vernux@us.ibm.com>
      Signed-off-by: default avatarAmit Kumar Salecha <amit.salecha@qlogic.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      41f3e0b1
    • Nick Pelly's avatar
      Bluetooth: Enter active mode before establishing a SCO link. · c390216b
      Nick Pelly authored
      
      
      When in sniff mode with a long interval time (1.28s) it can take 4+ seconds
      to establish a SCO link. Fix by requesting active mode before requesting
      SCO connection. This improves SCO setup time to ~500ms.
      
      Bluetooth headsets that use a long interval time, and exhibit the long
      SCO connection time include Motorola H790, HX1 and H17. They have a
      CSR 2.1 chipset.
      
      Verified this behavior and fix with host Bluetooth chipsets: BCM4329 and
      TI1271.
      
      2009-10-13 14:17:46.183722 > HCI Event: Mode Change (0x14) plen 6
          status 0x00 handle 1 mode 0x02 interval 2048
          Mode: Sniff
      2009-10-13 14:17:53.436285 < HCI Command: Setup Synchronous Connection (0x01|0x0028) plen 17
          handle 1 voice setting 0x0060
      2009-10-13 14:17:53.445593 > HCI Event: Command Status (0x0f) plen 4
          Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
      2009-10-13 14:17:57.788855 > HCI Event: Synchronous Connect Complete 0x2c) plen 17
          status 0x00 handle 257 bdaddr 00:1A:0E:F1:A4:7F type eSCO
          Air mode: CVSD
      Signed-off-by: default avatarNick Pelly <npelly@google.com>
      Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
      c390216b
    • Yoichi Yuasa's avatar
    • Gerrit Renker's avatar
      dccp: fix auto-loading of dccp(_probe) · 1386be55
      Gerrit Renker authored
      This fixes commit (38ff3e6b
      
      ) ("dccp_probe:
      Fix module load dependencies between dccp and dccp_probe", from 15 Jan).
      
      It fixes the construction of the first argument of try_then_request_module(),
      where only valid return codes from the first argument should be returned.
      
      What we do now is assign the result of register_jprobe() to ret, without
      the side effect of the comparison.
      Acked-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1386be55
    • Gerrit Renker's avatar
      dccp: fix bug in cache allocation · 8ed030dd
      Gerrit Renker authored
      This fixes a bug introduced in commit de4ef86c
      
      
      ("dccp: fix dccp rmmod when kernel configured to use slub", 17 Jan): the
      vsnprintf used sizeof(slab_name_fmt), which became truncated to 4 bytes, since
      slab_name_fmt is now a 4-byte pointer and no longer a 32-character array.
      
      This lead to error messages such as
       FATAL: Error inserting dccp: No buffer space available
      
       >> kernel: [ 1456.341501] kmem_cache_create: duplicate cache cci
      generated due to the truncation after the 3rd character.
      
      Fixed for the moment by introducing a symbolic constant. Tested to fix the bug.
      Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8ed030dd
    • stephen hemminger's avatar
      sky2: fix transmit DMA map leakage · f6815077
      stephen hemminger authored
      
      
      The book keeping structure for transmit always had the flags value
      cleared so transmit DMA maps were never released correctly.
      Based on patch by Jarek Poplawski, problem observed by Michael Breuer.
      Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f6815077
    • Alexey Dobriyan's avatar
      netlink: fix for too early rmmod · 974c37e9
      Alexey Dobriyan authored
      
      
      Netlink code does module autoload if protocol userspace is asking for is
      not ready. However, module can dissapear right after it was autoloaded.
      Example: modprobe/rmmod stress-testing and xfrm_user.ko providing NETLINK_XFRM.
      
      netlink_create() in such situation _will_ create userspace socket and
      _will_not_ pin module. Now if module was removed and we're going to call
      ->netlink_rcv into nothing:
      
      BUG: unable to handle kernel paging request at ffffffffa02f842a
      					       ^^^^^^^^^^^^^^^^
      	modules are loaded near these addresses here
      
      IP: [<ffffffffa02f842a>] 0xffffffffa02f842a
      PGD 161f067 PUD 1623063 PMD baa12067 PTE 0
      Oops: 0010 [#1] PREEMPT SMP DEBUG_PAGEALLOC
      last sysfs file: /sys/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/uevent
      CPU 1
      Pid: 11515, comm: ip Not tainted 2.6.33-rc5-netns-00594-gaaa5728-dirty #6 P5E/P5E
      RIP: 0010:[<ffffffffa02f842a>]  [<ffffffffa02f842a>] 0xffffffffa02f842a
      RSP: 0018:ffff8800baa3db48  EFLAGS: 00010292
      RAX: ffff8800baa3dfd8 RBX: ffff8800be353640 RCX: 0000000000000000
      RDX: ffffffff81959380 RSI: ffff8800bab7f130 RDI: 0000000000000001
      RBP: ffff8800baa3db58 R08: 0000000000000001 R09: 0000000000000000
      R10: 0000000000000001 R11: 0000000000000001 R12: 0000000000000011
      R13: ffff8800be353640 R14: ffff8800bcdec240 R15: ffff8800bd488010
      FS:  00007f93749656f0(0000) GS:ffff880002300000(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      CR2: ffffffffa02f842a CR3: 00000000ba82b000 CR4: 00000000000006e0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      Process ip (pid: 11515, threadinfo ffff8800baa3c000, task ffff8800bab7eb30)
      Stack:
       ffffffff813637c0 ffff8800bd488000 ffff8800baa3dba8 ffffffff8136397d
      <0> 0000000000000000 ffffffff81344adc 7fffffffffffffff 0000000000000000
      <0> ffff8800baa3ded8 ffff8800be353640 ffff8800bcdec240 0000000000000000
      Call Trace:
       [<ffffffff813637c0>] ? netlink_unicast+0x100/0x2d0
       [<ffffffff8136397d>] netlink_unicast+0x2bd/0x2d0
      
      	netlink_unicast_kernel:
      		nlk->netlink_rcv(skb);
      
       [<ffffffff81344adc>] ? memcpy_fromiovec+0x6c/0x90
       [<ffffffff81364263>] netlink_sendmsg+0x1d3/0x2d0
       [<ffffffff8133975b>] sock_sendmsg+0xbb/0xf0
       [<ffffffff8106cdeb>] ? __lock_acquire+0x27b/0xa60
       [<ffffffff810a18c3>] ? might_fault+0x73/0xd0
       [<ffffffff810a18c3>] ? might_fault+0x73/0xd0
       [<ffffffff8106db22>] ? __lock_release+0x82/0x170
       [<ffffffff810a190e>] ? might_fault+0xbe/0xd0
       [<ffffffff810a18c3>] ? might_fault+0x73/0xd0
       [<ffffffff81344c77>] ? verify_iovec+0x47/0xd0
       [<ffffffff8133a509>] sys_sendmsg+0x1a9/0x360
       [<ffffffff813c2be5>] ? _raw_spin_unlock_irqrestore+0x65/0x70
       [<ffffffff8106aced>] ? trace_hardirqs_on+0xd/0x10
       [<ffffffff813c2bc2>] ? _raw_spin_unlock_irqrestore+0x42/0x70
       [<ffffffff81197004>] ? __up_read+0x84/0xb0
       [<ffffffff8106ac95>] ? trace_hardirqs_on_caller+0x145/0x190
       [<ffffffff813c207f>] ? trace_hardirqs_on_thunk+0x3a/0x3f
       [<ffffffff8100262b>] system_call_fastpath+0x16/0x1b
      Code:  Bad RIP value.
      RIP  [<ffffffffa02f842a>] 0xffffffffa02f842a
       RSP <ffff8800baa3db48>
      CR2: ffffffffa02f842a
      
      If module was quickly removed after autoloading, return -E.
      
      Return -EPROTONOSUPPORT if module was quickly removed after autoloading.
      Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      974c37e9
    • Alexey Dobriyan's avatar
      af_key: fix netns ops ordering on module load/unload · 180211b8
      Alexey Dobriyan authored
      
      
      1. After sock_register() returns, it's possible to create sockets,
         even if module still not initialized fully (blame generic module code
         for that!)
      2. Consequently, pfkey_create() can be called with pfkey_net_id still not
         initialized which will BUG_ON in net_generic():
      	kernel BUG at include/net/netns/generic.h:43!
      3. During netns shutdown, netns ops should be unregistered after
         key manager unregistered because key manager calls can be triggered
         from xfrm_user module:
      
         	general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
      	pfkey_broadcast+0x111/0x210 [af_key]
      	pfkey_send_notify+0x16a/0x300 [af_key]
      	km_state_notify+0x41/0x70
      	xfrm_flush_sa+0x75/0x90 [xfrm_user]
      4. Unregister netns ops after socket ops just in case and for symmetry.
      
      Reported by Luca Tettamanti.
      Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      Tested-by: default avatarLuca Tettamanti <kronos.it@gmail.com>
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      180211b8
    • Nick Pelly's avatar
      Bluetooth: Do not call rfcomm_session_put() for RFCOMM UA on closed socket · 6c2718da
      Nick Pelly authored
      
      
      When processing a RFCOMM UA frame when the socket is closed and we were
      not the RFCOMM initiator would cause rfcomm_session_put() to be called
      twice during rfcomm_process_rx(). This would cause a kernel panic in
      rfcomm_session_close() then.
      
      This could be easily reproduced during disconnect with devices such as
      Motorola H270 that send RFCOMM UA followed quickly by L2CAP disconnect
      request. This trace for this looks like:
      
      2009-09-21 17:22:37.788895 < ACL data: handle 1 flags 0x02 dlen 8
         L2CAP(d): cid 0x0041 len 4 [psm 3]
           RFCOMM(s): DISC: cr 0 dlci 20 pf 1 ilen 0 fcs 0x7d
      2009-09-21 17:22:37.906204 > HCI Event: Number of Completed Packets (0x13) plen 5
         handle 1 packets 1
      2009-09-21 17:22:37.933090 > ACL data: handle 1 flags 0x02 dlen 8
         L2CAP(d): cid 0x0040 len 4 [psm 3]
           RFCOMM(s): UA: cr 0 dlci 20 pf 1 ilen 0 fcs 0x57
      2009-09-21 17:22:38.636764 < ACL data: handle 1 flags 0x02 dlen 8
         L2CAP(d): cid 0x0041 len 4 [psm 3]
           RFCOMM(s): DISC: cr 0 dlci 0 pf 1 ilen 0 fcs 0x9c
      2009-09-21 17:22:38.744125 > HCI Event: Number of Completed Packets (0x13) plen 5
         handle 1 packets 1
      2009-09-21 17:22:38.763687 > ACL data: handle 1 flags 0x02 dlen 8
         L2CAP(d): cid 0x0040 len 4 [psm 3]
           RFCOMM(s): UA: cr 0 dlci 0 pf 1 ilen 0 fcs 0xb6
      2009-09-21 17:22:38.783554 > ACL data: handle 1 flags 0x02 dlen 12
         L2CAP(s): Disconn req: dcid 0x0040 scid 0x0041
      
      Avoid calling rfcomm_session_put() twice by skipping this call
      in rfcomm_recv_ua() if the socket is closed.
      Signed-off-by: default avatarNick Pelly <npelly@google.com>
      Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
      6c2718da