1. 11 Feb, 2017 1 commit
    • Ard Biesheuvel's avatar
      crypto: algapi - make crypto_xor() and crypto_inc() alignment agnostic · db91af0f
      Ard Biesheuvel authored
      Instead of unconditionally forcing 4 byte alignment for all generic
      chaining modes that rely on crypto_xor() or crypto_inc() (which may
      result in unnecessary copying of data when the underlying hardware
      can perform unaligned accesses efficiently), make those functions
      deal with unaligned input explicitly, but only if the Kconfig symbol
      HAVE_EFFICIENT_UNALIGNED_ACCESS is set. This will allow us to drop
      the alignmasks from the CBC, CMAC, CTR, CTS, PCBC and SEQIV drivers.
      For crypto_inc(), this simply involves making the 4-byte stride
      conditional on HAVE_EFFICIENT_UNALIGNED_ACCESS being set, given that
      it typically operates on 16 byte buffers.
      For crypto_xor(), an algorithm is implemented that simply runs through
      the input using the largest strides possible if unaligned accesses are
      allowed. If they are not, an optimal sequence of memory accesses is
      emitted that takes the relative alignment of the input buffers into
      account, e.g., if the relative misalignment of dst and src is 4 bytes,
      the entire xor operation will be completed using 4 byte loads and stores
      (modulo unaligned bits at the start and end). Note that all expressions
      involving misalign are simply eliminated by the compiler when
      Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
  2. 18 Jul, 2016 2 commits
  3. 17 Aug, 2015 3 commits
  4. 14 Jul, 2015 1 commit
    • Herbert Xu's avatar
      crypto: seqiv - Replace seqniv with seqiv · 5964f26c
      Herbert Xu authored
      This patch replaces the seqniv generator with seqiv when the
      underlying algorithm understands the new calling convention.
      This not only makes more sense as now seqiv is solely responsible
      for IV generation rather than also determining how the IV is going
      to be used, it also allows for optimisations in the underlying
      implementation.  For example, the space for the IV could be used
      to add padding for authentication.
      This patch also removes the unnecessary copying of IV to dst
      during seqiv decryption as the IV is part of the AD and not cipher
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
  5. 22 Jun, 2015 1 commit
  6. 04 Jun, 2015 1 commit
  7. 28 May, 2015 4 commits
  8. 25 May, 2015 3 commits
    • Herbert Xu's avatar
      crypto: aead - Remove unused cryptoff parameter · 374d4ad1
      Herbert Xu authored
      This patch removes the cryptoff parameter now that all users
      set it to zero.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    • Herbert Xu's avatar
      crypto: seqiv - Stop using cryptoff · dd04446e
      Herbert Xu authored
      The cryptoff parameter was added to facilitate the skipping of
      IVs that sit between the AD and the plain/cipher text.  However,
      it was never implemented correctly as and we do not handle users
      such as IPsec setting cryptoff.  It is simply ignored.
      Implementing correctly is in fact more trouble than what it's
      This patch removes the uses of cryptoff by moving the AD forward
      to fill the gap left by the IV.  The AD is moved back after the
      underlying AEAD processing is finished.
      This is in fact beter than the cryptoff solution because it allows
      algorithms that use seqniv (i.e., GCM and CCM) to hash the whole
      packet as a single piece, while cryptoff meant that there was
      guaranteed to be a gap.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    • Herbert Xu's avatar
      crypto: seqiv - Use aead_register_instance · 0677157b
      Herbert Xu authored
      New style AEAD instances must use aead_register_instance.  This
      worked by chance because aead_geniv_alloc is still setting things
      the old way.
      This patch converts the template over to the create model where
      we are responsible for instance registration so that we can call
      the correct function.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
  9. 22 May, 2015 2 commits
    • Herbert Xu's avatar
      crypto: seqiv - Add seqniv · 3c08fee7
      Herbert Xu authored
      This patch adds a new IV generator seqniv which is identical to
      seqiv except that it skips the IV when authenticating.  This is
      intended to be used by algorithms such as rfc4106 that does the
      IV authentication implicitly.
      Note that the code used for seqniv is in fact identical to the
      compatibility case for seqiv.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    • Herbert Xu's avatar
      crypto: seqiv - Add support for new AEAD interface · 856e3f40
      Herbert Xu authored
      This patch converts the seqiv IV generator to work with the new
      AEAD interface where IV generators are just normal AEAD algorithms.
      Full backwards compatibility is paramount at this point since
      no users have yet switched over to the new interface.  Nor can
      they switch to the new interface until IV generation is fully
      supported by it.
      So this means we are adding two versions of seqiv alongside the
      existing one.  The first one is the one that will be used when
      the underlying AEAD algorithm has switched over to the new AEAD
      interface.  The second one handles the current case where the
      underlying AEAD algorithm still uses the old interface.
      Both versions export themselves through the new AEAD interface.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
  10. 13 May, 2015 1 commit
  11. 20 Jan, 2015 1 commit
  12. 26 Nov, 2014 1 commit
  13. 01 Aug, 2014 1 commit
  14. 04 Feb, 2013 1 commit
  15. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  16. 29 Aug, 2008 1 commit
  17. 10 Jan, 2008 2 commits