Skip to content
  • Will Deacon's avatar
    arm64: debug: don't re-enable debug exceptions on return from el1_dbg · 1059c6bf
    Will Deacon authored
    When returning from a debug exception taken from EL1, we unmask debug
    exceptions after handling the exception. This is crucial for debug
    exceptions taken from EL0, so that any kernel work on the ret_to_user
    path can be debugged by kgdb.
    
    However, when returning back to EL1 the only thing left to do is to
    restore the original register state before the exception return. If
    single-step has been enabled by the debug exception handler, we will
    get stuck in an infinite debug exception loop, since we will take the
    step exception as soon as we unmask debug exceptions.
    
    This patch avoids unmasking debug exceptions on the debug exception
    return path when the exception was taken from EL1.
    
    Fixes: 2a283070
    
     (arm64: debug: avoid accessing mdscr_el1 on fault paths where possible)
    Cc: <stable@vger.kernel.org> #3.16+
    Reported-by: default avatarDavid Long <dave.long@linaro.org>
    Reported-by: default avatarAKASHI Takahiro <takahiro.akashi@linaro.org>
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    1059c6bf