• Subhash Jadavani's avatar
    scsi: ufs: fix race between clock gating and devfreq scaling work · 30fc33f1
    Subhash Jadavani authored
    
    
    UFS devfreq clock scaling work may require clocks to be ON if it need to
    execute some UFS commands hence it may request for clock hold before
    issuing the command. But if UFS clock gating work is already running in
    parallel, ungate work would end up waiting for the clock gating work to
    finish and as clock gating work would also wait for the clock scaling
    work to finish, we would enter in deadlock state. Here is the call trace
    during this deadlock state:
    
    Workqueue: devfreq_wq devfreq_monitor
    	__switch_to
    	__schedule
    	schedule
    	schedule_timeout
    	wait_for_common
    	wait_for_completion
    	flush_work
    	ufshcd_hold
    	ufshcd_send_uic_cmd
    	ufshcd_dme_get_attr
    	ufs_qcom_set_dme_vs_core_clk_ctrl_clear_div
    	ufs_qcom_clk_scale_notify
    	ufshcd_scale_clks
    	ufshcd_devfreq_target
    	update_devfreq
    	devfreq_monitor
    	process_one_work
    	worker_thread
    	kthread
    	ret_from_fork
    
    Workqueue: events ufshcd_gate_work
    	__switch_to
    	__schedule
    	schedule
    	schedule_preempt_disabled
    	__mutex_lock_slowpath
    	mutex_lock
    	devfreq_monitor_suspend
    	devfreq_simple_ondemand_handler
    	devfreq_suspend_device
    	ufshcd_gate_work
    	process_one_work
    	worker_thread
    	kthread
    	ret_from_fork
    
    Workqueue: events ufshcd_ungate_work
    	__switch_to
    	__schedule
    	schedule
    	schedule_timeout
    	wait_for_common
    	wait_for_completion
    	flush_work
    	__cancel_work_timer
    	cancel_delayed_work_sync
    	ufshcd_ungate_work
    	process_one_work
    	worker_thread
    	kthread
    	ret_from_fork
    
    This change fixes this deadlock by doing this in devfreq work (devfreq_wq):
    Try cancelling clock gating work. If we are able to cancel gating work
    or it wasn't scheduled, hold the clock reference count until scaling is
    in progress. If gate work is already running in parallel, let's skip
    the frequecy scaling at this time and it will be retried once next scaling
    window expires.
    Reviewed-by: default avatarSahitya Tummala <stummala@codeaurora.org>
    Signed-off-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    30fc33f1
ufshcd.c 173 KB