Skip to content
  • Steven Rostedt's avatar
    perf tools: Use strsep() over strtok_r() for parsing single line · 4e3b799d
    Steven Rostedt authored
    
    
    The second argument in the strtok_r() function is not to be used
    generically and can have different implementations. Currently
    the function parsing of the perf trace code uses the second
    argument to copy data from. This can crash the tool or just have
    unpredictable results.
    
    The correct solution is to use strsep() which has a defined
    result.
    
    I also added a check to see if the result was correct, and will
    break out of the loop in case it fails to parse as expected.
    
    Reported-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    LKML-Reference: <20091020232034.237814877@goodmis.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    4e3b799d