• Johan Hovold's avatar
    NFC: nfcmrvl_uart: fix OF child-node lookup · 737d47bd
    Johan Hovold authored
    [ Upstream commit 5bf59773aaf36dd62117dc83d50e1bbf9ef432da ]
    Use the new of_get_compatible_child() helper to lookup the nfc child
    node instead of using of_find_compatible_node(), which searches the
    entire tree from a given start node and thus can return an unrelated
    (i.e. non-child) node.
    This also addresses a potential use-after-free (e.g. after probe
    deferral) as the tree-wide helper drops a reference to its first
    argument (i.e. the parent node).
    Fixes: e097dc62 ("NFC: nfcmrvl: add UART driver")
    Fixes: d8e018c0 ("NFC: nfcmrvl: update device tree bindings for Marvell NFC")
    Cc: stable <stable@vger.kernel.org>     # 4.2
    Cc: Vincent Cuissard <cuissard@marvell.com>
    Cc: Samuel Ortiz <sameo@linux.intel.com>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    Signed-off-by: default avatarRob Herring <robh@kernel.org>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
uart.c 5.84 KB