Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • I ipipe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • xenomai
  • ipipe
  • Repository

Switch branch/tag
  • ipipe
  • scripts
  • checkpatch.pl
Find file BlameHistoryPermalink
  • Joe Perches's avatar
    checkpatch: more comprehensive split strings warning · 8c5fcd24
    Joe Perches authored Jan 23, 2014
    
    
    The current checkpatch test for split strings does not find several
    cases that should be found.
    
    For instance:
    
     		/* Else poor success; go back to mode in "active" table */
     		} else {
     			IWL_DEBUG_RATE(mvm,
    -				       "LQ: GOING BACK TO THE OLD TABLE suc=%d cur-tpt=%d old-tpt=%d\n",
    +				       "GOING BACK TO THE OLD TABLE: SR %d "
    +				       "cur-tpt %d old-tpt %d\n",
     				       window->success_ratio,
     				       window->average_tpt,
     				      lq_sta->last_tpt);
    
    does not currently emit a warning.
    
    Improve the test to find these cases.
    
    Add more exceptions to reduce false positives for assembly and octal/hex
    string constants.
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    8c5fcd24

Replace checkpatch.pl

Attach a file by drag & drop or click to upload


Cancel
GitLab will create a branch in your fork and start a merge request.

Imprint & Privacy Policy