Skip to content
  • Vegard Nossum's avatar
    x86: don't destroy %rbp on kernel-mode faults · 9d8ad5d6
    Vegard Nossum authored
    
    
    From the code:
    
        "B stepping K8s sometimes report an truncated RIP for IRET exceptions
        returning to compat mode. Check for these here too."
    
    The code then proceeds to truncate the upper 32 bits of %rbp. This means
    that when do_page_fault() is finally called, its prologue,
    
        do_page_fault:
            push %rbp
            movl %rsp, %rbp
    
    will put the truncated base pointer on the stack. This means that the
    stack tracer will not be able to follow the base-pointer changes and
    will see all subsequent stack frames as unreliable.
    
    This patch changes the code to use a different register (%rcx) for the
    checking and leaves %rbp untouched.
    
    Signed-off-by: default avatarVegard Nossum <vegard.nossum@gmail.com>
    Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
    Acked-by: default avatarArjan van de Ven <arjan@linux.intel.com>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: Pekka Enberg <penberg@cs.helsinki.fi>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    9d8ad5d6