Skip to content
  • Bodo Stroesser's avatar
    [PATCH] SYSEMU: fix sysaudit / singlestep interaction · ab1c23c2
    Bodo Stroesser authored
    
    
          Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    
    This is simply an adjustment for "Ptrace - i386: fix Syscall Audit interaction
    with singlestep" to work on top of SYSEMU patches, too.  On this patch, I have
    some doubts: I wonder why we need to alter that way ptrace_disable().
    
    I left the patch this way because it has been extensively tested, but I don't
    understand the reason.
    
    The current PTRACE_DETACH handling simply clears child->ptrace; actually this
    is not enough because entry.S just looks at the thread_flags; actually,
    do_syscall_trace checks current->ptrace but I don't think depending on that is
    good, at least for performance, so I think the clearing is done elsewhere.
    For instance, on PTRACE_CONT it's done, but doing PTRACE_DETACH without
    PTRACE_CONT is possible (and happens when gdb crashes and one kills it
    manually).
    
    Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    CC: Roland McGrath <roland@redhat.com>
    Cc: Jeff Dike <jdike@addtoit.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    ab1c23c2