Skip to content
  • Linus Torvalds's avatar
    Revert "[PATCH] binfmt_elf: randomize PIE binaries (2nd try)" · 90cb28e8
    Linus Torvalds authored
    This reverts commit 59287c09
    
    .
    
    Hugh Dickins reports that it causes random failures on x86 with SuSE
    10.2, and points out
    
      "Isn't that randomization, anywhere from 0x10000 to ELF_ET_DYN_BASE,
       sure to place the ET_DYN from time to time just where the comment
       says it's trying to avoid? I assume that somehow results in the error
       reported."
    
    (where the comment in question is the existing comment in the source
    code about mmap/brk clashes).
    
    Suggested-by: default avatarHugh Dickins <hugh@veritas.com>
    Acked-by: default avatarMarcus Meissner <meissner@suse.de>
    Cc: Andrew Morton <akpm@osdl.org>
    Cc: Andi Kleen <ak@suse.de>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Dave Jones <davej@codemonkey.org.uk>
    Cc: Arjan van de Ven <arjan@linux.intel.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    90cb28e8