• Nicolai Stange's avatar
    lib/mpi: mpi_read_from_buffer(): sanitize short buffer printk · cdf24b42
    Nicolai Stange authored
    The first two bytes of the input buffer encode its expected length and
    mpi_read_from_buffer() prints a console message if the given buffer is too
    However, there are some oddities with how this message is printed:
    - It is printed at the default loglevel. This is different from the
      one used in the case that the first two bytes' value is unsupportedly
      large, i.e. KERN_INFO.
    - The format specifier '%d' is used for unsigned ints.
    - It prints the values of nread and *ret_nread. This is redundant since
      the former is always the latter + 1.
    Clean this up as follows:
    - Use pr_info() rather than printk() with no loglevel.
    - Use the format specifiers '%u' in place if '%d'.
    - Do not print the redundant 'nread' but the more helpful 'nbytes' value.
    Signed-off-by: default avatarNicolai Stange <nicstange@gmail.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>