• Grazvydas Ignotas's avatar
    Revert "wl1251: enforce changed hw encryption support on monitor state change" · d5738b41
    Grazvydas Ignotas authored
    This reverts commit b90a1165
    That commit (or rather, hack) triggers a scary WARN in IBSS (ad-hoc) mode.
    Steps to reproduce:
        ifconfig wlan0 down
        iwconfig wlan0 mode ad-hoc
        ifconfig wlan0 up
    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 905 at kernel/workqueue.c:1400 __queue_work+0x21c/0x2f4()
    Modules linked in: wl1251_sdio wl1251 mac80211 cfg80211
    CPU: 0 PID: 905 Comm: ifconfig Not tainted 3.15.0-rc2#233
    [<c0015f38>] (unwind_backtrace) from [<c0012938>]
    [<c0012938>] (show_stack) from [<c05d4034>]
    [<c05d4034>] (dump_stack) from [<c0043984>]
    [<c0043984>] (warn_slowpath_common) from [<c00439c0>]
    [<c00439c0>] (warn_slowpath_null) from [<c005b6c8>]
    [<c005b6c8>] (__queue_work) from [<c005b820>]
    [<c005b820>] (queue_work_on) from [<bf134ac0>]
    [<bf134ac0>] (wl1251_op_config [wl1251])
    [<bf099a70>] (ieee80211_hw_config [mac80211])
    This happens because ieee80211_connection_loss() is not expected to be
    called in IBSS mode (mac80211 ends up queuing uninitialized work
    in that case).
    Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
    Tested-by: default avatarPali Rohár <pali.rohar@gmail.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>