Commit 06efbeb4 authored by Oliver Neukum's avatar Oliver Neukum Committed by Linus Torvalds
Browse files

hp_accel: fix race in device removal



The work queue has to be flushed after the device has been made
inaccessible.  The patch closes a window during which a work queue might
remain active after the device is removed and would then lead to ACPI
calls with undefined behavior.
Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Acked-by: default avatarEric Piel <eric.piel@tremplin-utc.net>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Cc: Pavel Herrmann <morpheus.ibis@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a3ed2a15
......@@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
lis3lv02d_joystick_disable();
lis3lv02d_poweroff(&lis3_dev);
flush_work(&hpled_led.work);
led_classdev_unregister(&hpled_led.led_classdev);
flush_work(&hpled_led.work);
return lis3lv02d_remove_fs(&lis3_dev);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment