Commit 1db01b49 authored by Stefan Bader's avatar Stefan Bader Committed by Konrad Rzeszutek Wilk
Browse files

xen: Clean up apic ipi interface

Commit f447d56d

 introduced the
implementation of the PV apic ipi interface. But there were some
odd things (it seems none of which cause really any issue but
maybe they should be cleaned up anyway):
 - xen_send_IPI_mask_allbutself (and by that xen_send_IPI_allbutself)
   ignore the passed in vector and only use the CALL_FUNCTION_SINGLE
   vector. While xen_send_IPI_all and xen_send_IPI_mask use the vector.
 - physflat_send_IPI_allbutself is declared unnecessarily. It is never

This patch tries to clean up those things.
Signed-off-by: default avatarStefan Bader <>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <>
parent 33c1174b
......@@ -576,24 +576,22 @@ void xen_send_IPI_mask_allbutself(const struct cpumask *mask,
unsigned cpu;
unsigned int this_cpu = smp_processor_id();
int xen_vector = xen_map_vector(vector);
if (!(num_online_cpus() > 1))
if (!(num_online_cpus() > 1) || (xen_vector < 0))
for_each_cpu_and(cpu, mask, cpu_online_mask) {
if (this_cpu == cpu)
xen_send_IPI_one(cpu, xen_vector);
void xen_send_IPI_allbutself(int vector)
int xen_vector = xen_map_vector(vector);
if (xen_vector >= 0)
xen_send_IPI_mask_allbutself(cpu_online_mask, xen_vector);
xen_send_IPI_mask_allbutself(cpu_online_mask, vector);
static irqreturn_t xen_call_function_interrupt(int irq, void *dev_id)
......@@ -5,7 +5,6 @@ extern void xen_send_IPI_mask(const struct cpumask *mask,
extern void xen_send_IPI_mask_allbutself(const struct cpumask *mask,
int vector);
extern void xen_send_IPI_allbutself(int vector);
extern void physflat_send_IPI_allbutself(int vector);
extern void xen_send_IPI_all(int vector);
extern void xen_send_IPI_self(int vector);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment