Commit 2b1d3ae9 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

fs/binfmt_elf.c:load_elf_binary(): return -EINVAL on zero-length mappings

load_elf_binary() returns `retval', not `error'.

Fixes: a87938b2

 ("fs/binfmt_elf.c: fix bug in loading of PIE binaries")
Reported-by: default avatarJames Hogan <>
Cc: Michael Davidson <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 649b8de2
...@@ -918,7 +918,7 @@ static int load_elf_binary(struct linux_binprm *bprm) ...@@ -918,7 +918,7 @@ static int load_elf_binary(struct linux_binprm *bprm)
total_size = total_mapping_size(elf_phdata, total_size = total_mapping_size(elf_phdata,
loc->elf_ex.e_phnum); loc->elf_ex.e_phnum);
if (!total_size) { if (!total_size) {
error = -EINVAL; retval = -EINVAL;
goto out_free_dentry; goto out_free_dentry;
} }
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment