Commit 4344b813 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/i915: ignore eDP bpc settings from vbt

This has originally been introduced to not oversubscribe the dp links

commit 885a5fb5

Author: Zhenyu Wang <>
Date:   Tue Jan 12 05:38:31 2010 +0800

    drm/i915: fix pixel color depth setting on eDP

Since then we've fixed up the dp link bandwidth calculation code and
should now automatically fall back to 6bpc dithering. So this is

Furthermore it seems to break the new MacbookPro with retina display,
hence let's just rip this out.
Reported-by: default avatarBenoit Gschwind <>
Cc: Benoit Gschwind <>
Cc: Francois Rigaut <>
Cc: Greg KH <>
Tested-by: default avatarBenoit Gschwind <>
Tested-by: Bernhard Froemel <froemel at vmars>
Signed-off-by: default avatarDaniel Vetter <>


Testing feedback highgly welcome, and thanks for Benoit for finding
out that the bpc computations are busted.
parent 770c1231
......@@ -3754,17 +3754,6 @@ static bool intel_choose_pipe_bpp_dither(struct drm_crtc *crtc,
if (intel_encoder->type == INTEL_OUTPUT_EDP) {
/* Use VBT settings if we have an eDP panel */
unsigned int edp_bpc = dev_priv->edp.bpp / 3;
if (edp_bpc < display_bpc) {
DRM_DEBUG_KMS("clamping display bpc (was %d) to eDP (%d)\n", display_bpc, edp_bpc);
display_bpc = edp_bpc;
/* Not one of the known troublemakers, check the EDID */
list_for_each_entry(connector, &dev->mode_config.connector_list,
head) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment