Commit 619a908a authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add error on use of attribute((weak)) or __weak declarations

Using weak declarations can have unintended link defects.  The __weak on
the declaration causes non-weak definitions to become weak.

Emit an error on its use.
Signed-off-by: default avatarJoe Perches <>
Reported-by: default avatarBjorn Helgaas <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 2381097b
......@@ -4671,6 +4671,15 @@ sub process {
# Check for __attribute__ weak, or __weak declarations (may have link issues)
if ($^V && $^V ge 5.10.0 &&
$line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
($line =~ /\b__attribute__\s*\(\s*\(.*\bweak\b/ ||
$line =~ /\b__weak\b/)) {
"Using weak declarations can have unintended link defects\n" . $herecurr);
# check for sizeof(&)
if ($line =~ /\bsizeof\s*\(\s*\&/) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment