Commit 76149750 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

net: bcmgenet: fix OF child-node lookup

[ Upstream commit d397dbe606120a1ea1b11b0020c3f7a3852da5ac ]

Use the new of_get_compatible_child() helper to lookup the mdio child
node instead of using of_find_compatible_node(), which searches the
entire tree from a given start node and thus can return an unrelated
(i.e. non-child) node.

This also addresses a potential use-after-free (e.g. after probe
deferral) as the tree-wide helper drops a reference to its first
argument (i.e. the node of the device being probed).

Fixes: aa09677c ("net: bcmgenet: add MDIO routines")
Cc: stable <>     # 3.15
Cc: David S. Miller <>
Reviewed-by: default avatarFlorian Fainelli <>
Signed-off-by: default avatarJohan Hovold <>
Signed-off-by: default avatarRob Herring <>
Signed-off-by: default avatarSasha Levin <>
parent 737d47bd
......@@ -491,7 +491,7 @@ static int bcmgenet_mii_of_init(struct bcmgenet_priv *priv)
if (!compat)
return -ENOMEM;
priv->mdio_dn = of_find_compatible_node(dn, NULL, compat);
priv->mdio_dn = of_get_compatible_child(dn, compat);
if (!priv->mdio_dn) {
dev_err(kdev, "unable to find MDIO bus node\n");
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment