Commit 7959722b authored by Jie Zhang's avatar Jie Zhang Committed by Linus Torvalds
Browse files

NOMMU: Use copy_*_user_page() in access_process_vm()

The MMU code uses the copy_*_user_page() variants in access_process_vm()
rather than copy_*_user() as the former includes an icache flush.  This
is important when doing things like setting software breakpoints with
gdb.  So switch the NOMMU code over to do the same.

This patch makes the reasonable assumption that copy_from_user_page()
won't fail - which is probably fine, as we've checked the VMA from which
we're copying is usable, and the copy is not allowed to cross VMAs.  The
one case where it might go wrong is if the VMA is a device rather than
RAM, and that device returns an error which - in which case rubbish will
be returned rather than EIO.
Signed-off-by: default avatarJie Zhang <>
Signed-off-by: default avatarMike Frysinger <>
Signed-off-by: default avatarDavid Howells <>
Acked-by: default avatarDavid McCullough <>
Acked-by: default avatarPaul Mundt <>
Acked-by: default avatarGreg Ungerer <>
Signed-off-by: default avatarLinus Torvalds <>
parent cfe79c00
......@@ -1921,9 +1921,11 @@ int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, in
/* only read or write mappings where it is permitted */
if (write && vma->vm_flags & VM_MAYWRITE)
len -= copy_to_user((void *) addr, buf, len);
copy_to_user_page(vma, NULL, addr,
(void *) addr, buf, len);
else if (!write && vma->vm_flags & VM_MAYREAD)
len -= copy_from_user(buf, (void *) addr, len);
copy_from_user_page(vma, NULL, addr,
buf, (void *) addr, len);
len = 0;
} else {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment