Commit 7eac7e9e authored by Pierre Habouzit's avatar Pierre Habouzit Committed by Ingo Molnar
Browse files

perf util: Fix do_read() to fail on EOF instead of busy-looping

While toying with perf, I've noticed that perf record can
easily enter a busy loop when doing something as silly as:

    $ perf record -A ls

Yeah, do_read here really wants to read a known size, not being
able to should die(), not busy-loop ;)

That was the cause for the bug.
Signed-off-by: default avatarPierre Habouzit <>
Acked-by: default avatarPeter Zijlstra <>
Cc: Paul Mackerras <>
Signed-off-by: default avatarIngo Molnar <>
parent ae07b63f
......@@ -185,6 +185,8 @@ static void do_read(int fd, void *buf, size_t size)
if (ret < 0)
die("failed to read");
if (ret == 0)
die("failed to read: missing data");
size -= ret;
buf += ret;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment