Commit 8895ef4e authored by Ding Pixel's avatar Ding Pixel Committed by Greg Kroah-Hartman
Browse files

drm/amdgpu: check ring being ready before using

[ Upstream commit c5f21c9f


Return success when the ring is properly initialized, otherwise return

Tonga SRIOV VF doesn't have UVD and VCE engines, the initialization of
these IPs is bypassed. The system crashes if application submit IB to
their rings which are not ready to use. It could be a common issue if
IP having ring buffer is disabled for some reason on specific ASIC, so
it should check the ring being ready to use.

Bug: amdgpu_test crashes system on Tonga VF.

Signed-off-by: default avatarDing Pixel <>
Reviewed-by: default avatarChristian König <>
Signed-off-by: default avatarAlex Deucher <>
Signed-off-by: default avatarSasha Levin <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent e5a2ba9a
......@@ -83,6 +83,13 @@ int amdgpu_cs_get_ring(struct amdgpu_device *adev, u32 ip_type,
if (!(*out_ring && (*out_ring)->adev)) {
DRM_ERROR("Ring %d is not initialized on IP %d\n",
ring, ip_type);
return -EINVAL;
return 0;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment