Commit b582ef5c authored by Maciej W. Rozycki's avatar Maciej W. Rozycki Committed by Al Viro
Browse files

binfmt_elf: Don't clobber passed executable's file header

Do not clobber the buffer space passed from `search_binary_handler' and
originally preloaded by `prepare_binprm' with the executable's file
header by overwriting it with its interpreter's file header.  Instead
keep the buffer space intact and directly use the data structure locally
allocated for the interpreter's file header, fixing a bug introduced in
2.1.14 with loadable module support ( commit beb11695
[Import of Linux/MIPS 2.1.14], predating repo's history).
Adjust the amount of data read from the interpreter's file accordingly.

This was not an issue before loadable module support, because back then
`load_elf_binary' was executed only once for a given ELF executable,
whether the function succeeded or failed.

With loadable module support supported and enabled, upon a failure of
`load_elf_binary' -- which may for example be caused by architecture
code rejecting an executable due to a missing hardware feature requested
in the file header -- a module load is attempted and then the function
reexecuted by `search_binary_handler'.  With the executable's file
header replaced with its interpreter's file header the executable can
then be erroneously accepted in this subsequent attempt.

Cc: # all the way back
Signed-off-by: default avatarMaciej W. Rozycki <>
Signed-off-by: default avatarAl Viro <>
parent 102f4d90
......@@ -759,16 +759,16 @@ static int load_elf_binary(struct linux_binprm *bprm)
would_dump(bprm, interpreter);
retval = kernel_read(interpreter, 0, bprm->buf,
if (retval != BINPRM_BUF_SIZE) {
/* Get the exec headers */
retval = kernel_read(interpreter, 0,
(void *)&loc->interp_elf_ex,
if (retval != sizeof(loc->interp_elf_ex)) {
if (retval >= 0)
retval = -EIO;
goto out_free_dentry;
/* Get the exec headers */
loc->interp_elf_ex = *((struct elfhdr *)bprm->buf);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment