Commit d0f63acc authored by Alex Williamson's avatar Alex Williamson Committed by Jeff Kirsher
Browse files

igb: Fix null pointer dereference

The max_vfs= option has always been self limiting to the number of VFs
supported by the device.  fa44f2f1

 added SR-IOV configuration via
sysfs, but in the process broke this self correction factor.  The
failing path is:

    if (max_vfs > 7) {
        adapter->vfs_allocated_count = 7;
    igb_enable_sriov(, max_vfs)
      if (num_vfs > 7) {
        err = -EPERM;

This leaves vfs_allocated_count = 7 and vf_data = NULL, so we bomb out
when igb_probe finally calls igb_reset.  It seems like a really bad
idea, and somewhat pointless, to set vfs_allocated_count separate from
vf_data, but limiting max_vfs is enough to avoid the null pointer.
Signed-off-by: default avatarAlex Williamson <>
Acked-by: default avatarGreg Rose <>
Tested-by: default avatarAaron Brown <>
Signed-off-by: default avatarJeff Kirsher <>
parent 22c12752
......@@ -2652,7 +2652,7 @@ static int igb_sw_init(struct igb_adapter *adapter)
if (max_vfs > 7) {
"Maximum of 7 VFs per PF, using max\n");
adapter->vfs_allocated_count = 7;
max_vfs = adapter->vfs_allocated_count = 7;
} else
adapter->vfs_allocated_count = max_vfs;
if (adapter->vfs_allocated_count)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment