Commit dd7271fe authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

[NETFILTER]: SCTP conntrack: fix crash triggered by packet without chunks



When a packet without any chunks is received, the newconntrack variable
in sctp_packet contains an out of bounds value that is used to look up an
pointer from the array of timeouts, which is then dereferenced, resulting
in a crash. Make sure at least a single chunk is present.

Problem noticed by George A. Theall <theall@tenablesecurity.com>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2c6059bc
...@@ -254,7 +254,7 @@ static int do_basic_checks(struct ip_conntrack *conntrack, ...@@ -254,7 +254,7 @@ static int do_basic_checks(struct ip_conntrack *conntrack,
} }
DEBUGP("Basic checks passed\n"); DEBUGP("Basic checks passed\n");
return 0; return count == 0;
} }
static int new_state(enum ip_conntrack_dir dir, static int new_state(enum ip_conntrack_dir dir,
......
...@@ -261,7 +261,7 @@ static int do_basic_checks(struct nf_conn *conntrack, ...@@ -261,7 +261,7 @@ static int do_basic_checks(struct nf_conn *conntrack,
} }
DEBUGP("Basic checks passed\n"); DEBUGP("Basic checks passed\n");
return 0; return count == 0;
} }
static int new_state(enum ip_conntrack_dir dir, static int new_state(enum ip_conntrack_dir dir,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment