Commit e85d0025 authored by Steffen Maier's avatar Steffen Maier Committed by Greg Kroah-Hartman
Browse files

scsi: zfcp: fix missing zfcp_port reference put on -EBUSY from port_remove

commit d27e5e07f9c49bf2a6a4ef254ce531c1b4fb5a38 upstream.

With this early return due to zfcp_unit child(ren), we don't use the
zfcp_port reference from the earlier zfcp_get_port_by_wwpn() anymore and
need to put it.
Signed-off-by: default avatarSteffen Maier <>
Fixes: d99b601b

 ("[SCSI] zfcp: restore refcount check on port_remove")
Cc: <> #3.7+
Reviewed-by: default avatarJens Remus <>
Reviewed-by: default avatarBenjamin Block <>
Signed-off-by: default avatarMartin K. Petersen <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 8282730a
......@@ -263,6 +263,7 @@ static ssize_t zfcp_sysfs_port_remove_store(struct device *dev,
if (atomic_read(&port->units) > 0) {
retval = -EBUSY;
put_device(&port->dev); /* undo zfcp_get_port_by_wwpn() */
goto out;
/* port is about to be removed, so no more unit_add */
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment