1. 09 Dec, 2009 1 commit
  2. 19 Nov, 2009 1 commit
    • Joe Perches's avatar
      drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg · 5452fee2
      Joe Perches authored
      
      
      Changed function pointer use from non-majority address-of style
      to majority short form without & via:
      
      grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
              perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
      done
      
      Compile tested allyesconfig x86
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      
       drivers/isdn/gigaset/bas-gigaset.c |    4 ++--
       drivers/isdn/gigaset/common.c      |    2 +-
       drivers/isdn/gigaset/interface.c   |    2 +-
       drivers/isdn/gigaset/ser-gigaset.c |    2 +-
       drivers/isdn/gigaset/usb-gigaset.c |    2 +-
       5 files changed, 6 insertions(+), 6 deletions(-)
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5452fee2
  3. 29 Oct, 2009 2 commits
  4. 07 Oct, 2009 4 commits
  5. 18 May, 2009 2 commits
  6. 26 Dec, 2008 1 commit
  7. 30 Nov, 2008 1 commit
  8. 24 Jul, 2008 1 commit
  9. 07 Mar, 2008 1 commit
    • Tilman Schmidt's avatar
      gigaset: fix Oops on module unload regression · 5d49c101
      Tilman Schmidt authored
      The card state mutex was only initialized when a device was connected,
      but used during unload unconditionally, leading to an Oops if a driver
      was loaded and unloaded again without ever connecting a device.
      
      Fix this by initializing the mutex as soon as the structure is allocated.
      Also add a missing mutex unlock revealed in the same execution path.
      
      This fixes a possible Oops in 2.6.25-rc that was introduced by commit
      e468c048
      
       ("Gigaset: permit module
      unload").
      
      Thanks to Roland Kletzing for reporting this problem.
      Signed-off-by: default avatarTilman Schmidt <tilman@imap.cc>
      Tested-by: default avatarRoland Kletzing <devzero@web.de>
      Cc: Hansjoerg Lipp <hjlipp@web.de>
      Cc: Karsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      5d49c101
  10. 06 Feb, 2008 2 commits
  11. 18 Oct, 2007 1 commit
    • Joe Perches's avatar
      Add missing newlines to some uses of dev_<level> messages · 898eb71c
      Joe Perches authored
      
      
      Found these while looking at printk uses.
      
      Add missing newlines to dev_<level> uses
      Add missing KERN_<level> prefixes to multiline dev_<level>s
      Fixed a wierd->weird spelling typo
      Added a newline to a printk
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Cc: "Luck, Tony" <tony.luck@intel.com>
      Cc: Jens Axboe <jens.axboe@oracle.com>
      Cc: Mark M. Hoffman <mhoffman@lightlink.com>
      Cc: Roland Dreier <rolandd@cisco.com>
      Cc: Tilman Schmidt <tilman@imap.cc>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Stephen Hemminger <shemminger@linux-foundation.org>
      Cc: Greg KH <greg@kroah.com>
      Cc: Jeremy Fitzhardinge <jeremy@goop.org>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: Alessandro Zummo <a.zummo@towertech.it>
      Cc: David Brownell <david-b@pacbell.net>
      Cc: James Smart <James.Smart@Emulex.Com>
      Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
      Cc: "Antonino A. Daplas" <adaplas@pol.net>
      Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
      Cc: Russell King <rmk@arm.linux.org.uk>
      Cc: Jaroslav Kysela <perex@suse.cz>
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      898eb71c
  12. 29 Mar, 2007 1 commit
  13. 12 Feb, 2007 2 commits
  14. 26 Jan, 2007 1 commit
  15. 08 Dec, 2006 1 commit
  16. 01 Dec, 2006 1 commit
  17. 06 Nov, 2006 1 commit
  18. 30 Oct, 2006 1 commit
  19. 28 Jun, 2006 1 commit
  20. 26 Jun, 2006 1 commit
  21. 21 Jun, 2006 1 commit
  22. 22 Apr, 2006 1 commit
    • Tilman Schmidt's avatar
      [PATCH] isdn4linux: Siemens Gigaset base driver: fix disconnect handling · 73a88814
      Tilman Schmidt authored
      
      
      Fix a possible Oops in the Siemens Gigaset base driver when the device is
      unplugged while an ISDN connection is still active, and makes sure that the
      isdn4linux link level (LL) is properly informed if a connection is broken
      by the USB cable being unplugged.
      
      - Avoid unsafe checks of URB status fields outside the URB completion
        handlers, keep track of in-use URBs myself instead.
      
      - If an isochronous transfer URB completes with status==0, also check the
        status of the frame descriptors.
      
      - Verify length of interrupt messages received from the device.
      
      - Align the length limit on transmitted AT commands with the device
        documentation.
      
      - In case of AT response receive overrun, keep newly arrived instead of old
        unread data.
      
      - Remove redundant check of device ID in the USB probe function.
      
      - Correct and improve some comments and formatting.
      Signed-off-by: default avatarTilman Schmidt <tilman@imap.cc>
      Acked-by: default avatarHansjoerg Lipp <hjlipp@web.de>
      Cc: Karsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      73a88814
  23. 11 Apr, 2006 11 commits