1. 10 Oct, 2008 38 commits
  2. 09 Oct, 2008 2 commits
    • Linus Torvalds's avatar
      Linux 2.6.27 · 3fa8749e
      Linus Torvalds authored
    • Linus Torvalds's avatar
      Don't allow splice() to files opened with O_APPEND · efc968d4
      Linus Torvalds authored
      This is debatable, but while we're debating it, let's disallow the
      combination of splice and an O_APPEND destination.
      It's not entirely clear what the semantics of O_APPEND should be, and
      POSIX apparently expects pwrite() to ignore O_APPEND, for example.  So
      we could make up any semantics we want, including the old ones.
      But Miklos convinced me that we should at least give it some thought,
      and that accepting writes at arbitrary offsets is wrong at least for
      IS_APPEND() files (which always have O_APPEND set, even if the reverse
      isn't true: you can obviously have O_APPEND set on a regular file).
      So disallow O_APPEND entirely for now.  I doubt anybody cares, and this
      way we have one less gray area to worry about.
      Reported-and-argued-for-by: default avatarMiklos Szeredi <miklos@szeredi.hu>
      Acked-by: default avatarJens Axboe <ens.axboe@oracle.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>