1. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  2. 08 Mar, 2010 1 commit
    • Uwe Kleine-König's avatar
      i2c: move i2c_omap's probe function to .devinit.text · 1139aea9
      Uwe Kleine-König authored
      
      
      A pointer to omap_i2c_probe is passed to the core via
      platform_driver_register and so the function must not disappear when the
      .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
      unbinding and binding a device to the driver via sysfs will result in an
      oops as does a device being registered late.
      
      An alternative to this patch is using platform_driver_probe instead of
      platform_driver_register plus removing the pointer to the probe function
      from the struct platform_driver.
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Cc: Kalle Jokiniemi <ext-kalle.jokiniemi@nokia.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Paul Walmsley <paul@pwsan.com>
      Cc: Richard Woodruff <r-woodruff2@ti.com>
      Cc: chandra shekhar <x0044955@ti.com>
      Cc: Jason P Marini <jason.marini@gmail.com>
      Cc: Syed Mohammed Khasim  <x0khasim@ti.com>
      Cc: Jarkko Nikula <jarkko.nikula@nokia.com>
      Cc: Juha Yrjola <juha.yrjola@solidboot.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      1139aea9
  3. 07 Mar, 2010 1 commit
  4. 24 Dec, 2009 2 commits
    • Manjunatha GK's avatar
      i2c-omap: OMAP3: Fix I2C lockup during timeout/error cases · 57eb81b1
      Manjunatha GK authored
      
      
      Current OMAP3 I2C driver code does not follow the correct sequence for soft
      reset. Due to this, lock up issues are reported during timeout/error cases.
      
      This patch fixes above issue by disabling I2C controller as per OMAP3430 TRM
      for soft reset. As per TRM, I2C controller needs to be disabled as a first
      step during soft reset.
      
      Here is correct soft reset sequence:
      a. Ensure that the module is disabled
      (clear the I2Ci.I2C_CON[15] I2C_EN bit to 0).
      b. Set the I2Ci.I2C_SYSC[1] SRST bit to 1.
      c. Enable the module by setting I2Ci.I2C_CON[15] I2C_EN bit to 1.
      d. Check the I2Ci.I2C_SYSS[0] RDONE bit until it is set to 1 to
      indicate the software reset is complete.
      
      Tested on Zoom2, Zoom3, 3430SDP and 3630SDP
      Signed-off-by: default avatarManjunatha GK <manjugk@ti.com>
      Signed-off-by: George, Harith<harith@ti.com>
      Acked-by: Varadarajan, Charu Latha<charu@ti.com>
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
      57eb81b1
    • Cory Maccarrone's avatar
      i2c-omap: Don't write IE state in unidle if 0 · 07ac31f6
      Cory Maccarrone authored
      Commit ef871432
      
      ... (i2c-omap: OMAP3: PM: (re)init for every transfer
      to support off-mode) introduced a change which make the dev->iestate
      contents be written to the OMAP_I2C_IE_REG every time omap_i2c_unidle
      is called.  Previously, the state was only written if it wasn't equal
      to zero.
      
      In omap_i2c_probe, omap_i2c_unidle() is called prior to omap_i2c_init(),
      in which case dev->iestate has not yet been initialized and will be set
      to zero.  Having this value written to the registers causes deadlock
      while booting.
      
      As such, this change restores the original functionality.
      Signed-off-by: default avatarCory Maccarrone <darkstar6262@gmail.com>
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
      07ac31f6
  5. 09 Dec, 2009 1 commit
    • Rajendra Nayak's avatar
      i2c-omap: OMAP3: PM: (re)init for every transfer to support off-mode · ef871432
      Rajendra Nayak authored
      
      
      Because of OMAP off-mode, powerdomain can go off when I2C is idle.
      Save enough state, and do a re-init for each transfer.
      
      Additional save/restore state added by Jagadeesh Bhaskar Pakaravoor
      (SYSC_REG) and Aaro Koskinen (wakeup sources.)
      
      Also, The OMAP3430 TRM states:
      
      "During active mode (I2Ci.I2C_CON[15] I2C_EN bit is set to 1), make no
      changes to the I2Ci.I2C_SCLL and I2Ci.I2C_SCLH registers.  Changes may
      result in unpredictable behavior."
      
      Hence, the I2C_EN bit should be clearer when modifying these
      registers. Please note that clearing the entire I2C_CON register to
      disable the I2C module is safe, because the I2C_CON register is
      re-configured for each transfer.
      Signed-off-by: default avatarJouni Hogander <jouni.hogander@nokia.com>
      Signed-off-by: default avatarRajendra Nayak <rnayak@ti.com>
      Cc: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
      Cc: Aaro Koskinen <aaro.koskinen@nokia.com>
      Cc: Jon Hunter <jon-hunter@ti.com>
      Cc: Hu Tao <taohu@motorola.com>
      Cc: Xiaolong Chen <A21785@motorola.com>
      Signed-off-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
      ef871432
  6. 20 Aug, 2009 3 commits
  7. 30 Jul, 2009 3 commits
  8. 29 Jul, 2009 1 commit
  9. 14 Jul, 2009 1 commit
  10. 22 Jun, 2009 1 commit
    • Tony Lindgren's avatar
      i2c-omap: Fix build breaking typo cpu_is_omap_2430 · ff0f2426
      Tony Lindgren authored
      Hi Ben,
      
      Can you please queue this fix?
      
      Thanks,
      
      Tony
      
      >From ffe2b2cdf6283770b70a197e3748c6b40a1006be Mon Sep 17 00:00:00 2001
      From: Tony Lindgren <tony@atomide.com>
      Date: Wed, 17 Jun 2009 13:14:23 +0300
      Subject: [PATCH] i2c-omap: Fix build breaking typo in cpu_is_omap_2430
      
      Commit 84bf2c86
      
       introduced a typo, it should be cpu_is_omap2430
      instead. The typo was probably caused by a mismerge.
      
      Without this patch all omaps fail to build with:
      error: implicit declaration of function 'cpu_is_omap_2430'
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
      ff0f2426
  11. 16 Jun, 2009 1 commit
    • Linus Walleij's avatar
      i2c: Use resource_size macro · c6ffddea
      Linus Walleij authored
      
      
      This replace all instances in the i2c busses tree of
      res->end - res->start + 1 with the handy macro resource_size(res)
      from ioport.h (coming in from platform_device.h).
      
      This was created with a simple
      sed -i -e 's/\([a-z]*\)->end *- *[a-z]*->start *+ *1/resource_size(\1)/g'
      
      Then manually replacing the PXA redefiniton of the same kind
      of macro manually. Recompiled some ARM defconfigs I could find to
      make a rough test so it shouldn't break anything, though I
      couldn't see exactly which configs you need for all the drivers.
      Signed-off-by: default avatarLinus Walleij <linus.walleij@stericsson.com>
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
      c6ffddea
  12. 13 Jun, 2009 2 commits
  13. 08 Feb, 2009 3 commits
  14. 16 Dec, 2008 1 commit
  15. 21 Nov, 2008 12 commits
  16. 05 Sep, 2008 1 commit
  17. 22 Apr, 2008 1 commit
  18. 23 Mar, 2008 1 commit
    • Tony Lindgren's avatar
      i2c-omap: Fix unhandled fault · f08ac4e7
      Tony Lindgren authored
      
      
      If an I2C interrupt happens between disabling interface clock
      and functional clock, the interrupt handler will produce an
      external abort on non-linefetch error when trying to access
      driver registers while interface clock is disabled.
      
      This patch fixes the problem by saving and disabling i2c-omap
      interrupt before turning off the clocks. Also disable functional
      clock before the interface clock as suggested by Paul Walmsley.
      
      Patch also renames enable/disable_clocks functions to unidle/idle
      functions. Note that the driver is currently not taking advantage
      of the idle interrupts. To use the idle interrupts, driver would
      have to enable interface clock based on the idle interrupt
      and dev->idle flag.
      
      This patch has been tested in linux-omap tree with various omaps.
      
      Cc: Paul Walmsley <paul@pwsan.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      f08ac4e7
  19. 27 Jan, 2008 1 commit
  20. 14 Jan, 2008 1 commit
  21. 12 Dec, 2007 1 commit