- 11 Dec, 2009 2 commits
-
-
Alan Cox authored
Split this into two flags - INIT meaning the board is set up and ACTIVE meaning the board has ports open. Remove the broken HUPCL casing and push the counts somewhere sensible. Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Alan Cox authored
Trivial conversion in this case so might as well do it while testing the port_open design is right Signed-off-by:
-
- 19 Sep, 2009 2 commits
-
-
Alan Cox authored
Again moving towards being able to add a common open method Signed-off-by: -
Alan Cox authored
Start to extract and build a model for a common tty_port_close() Signed-off-by:
-
- 12 Jul, 2009 1 commit
-
-
Alexey Dobriyan authored
* Remove smp_lock.h from files which don't need it (including some headers!) * Add smp_lock.h to files which do need it * Make smp_lock.h include conditional in hardirq.h It's needed only for one kernel_locked() usage which is under CONFIG_PREEMPT This will make hardirq.h inclusion cheaper for every PREEMPT=n config (which includes allmodconfig/allyesconfig, BTW) Signed-off-by:
Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
- 08 Jul, 2009 1 commit
-
-
Joe Perches authored
Commit 5fd29d6c ("printk: clean up handling of log-levels and newlines") changed printk semantics. printk lines with multiple KERN_<level> prefixes are no longer emitted as before the patch. <level> is now included in the output on each additional use. Remove all uses of multiple KERN_<level>s in formats. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
- 18 Jun, 2009 1 commit
-
-
Jiri Slaby authored
Fix this: isicom.c: In function `isicom_probe': isicom.c:1587: warning: `signature' may be used uninitialized in this function by uninitialized_var(), because if the signature is not initialized in reset_card(), we won't use it. Signed-off-by:
Jiri Slaby <jirislaby@gmail.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
- 11 Jun, 2009 1 commit
-
-
Alan Cox authored
Some drivers implement this internally, others miss it out. Push the behaviour into the core code as that way everyone will do it consistently. Update the dtr rts method to raise or lower depending upon flags. Having a single method in this style fits most of the implementations more cleanly than two funtions. We need this in place before we tackle the USB side Signed-off-by:
Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by:
-
- 06 Apr, 2009 1 commit
-
-
Alan Cox authored
The isicom driver leaks a kref on the shutdown path. Drop the additional kref we took Signed-off-by:
-
- 02 Jan, 2009 5 commits
-
-
Alan Cox authored
Again this is a lot of common code we can unify Signed-off-by:
Alan Cox <alan@redhat.com> Signed-off-by:
-
Alan Cox authored
Start sucking more commonality out of the drivers into a single piece of core code. Signed-off-by:
-
Alan Cox authored
This helps set the basis for moving block_til_ready into common code. We also introduce a tty_port_hangup helper as this will also be generally needed. Signed-off-by:
-
Alan Cox authored
This moves another per device special out of what should be shared open wait paths into private methods Signed-off-by:
-
Alan Cox authored
This is the first step to generalising the various pieces of waiting logic duplicated in all sorts of serial drivers. Signed-off-by:
-
- 11 Nov, 2008 1 commit
-
-
Alan Cox authored
Signed-off-by:
-
- 13 Oct, 2008 1 commit
-
-
Alan Cox authored
Rather than blindly keep taking krefs we reorder the code in a few places to pass the tty down to the right place (which is important as from the user side it is not the case that tty == port->tty in all situations). For the irq and related paths use the krefs to stop the tty being freed under us. Signed-off-by:
-
- 22 Jul, 2008 1 commit
-
-
Alan Cox authored
Signed-off-by:
-
- 21 Jul, 2008 3 commits
-
-
Alan Cox authored
Move more bits into the tty_port structure Signed-off-by:
-
Alan Cox authored
Switch isicom to use a tty_port structure for some fields Signed-off-by:
-
Jiri Slaby authored
Don't forget to enable and disable PCI devices. The device might be unusable without that. Signed-off-by:
-
- 30 Apr, 2008 5 commits
-
-
Alan Cox authored
Fix the rather strange buffer management on open that turned up while auditing for BKL dependencies. Signed-off-by:
-
Alan Cox authored
- Operations are now a shared const function block as with most other Linux objects - Introduce wrappers for some optional functions to get consistent behaviour - Wrap put_char which used to be patched by the tty layer - Document which functions are needed/optional - Make put_char report success/fail - Cache the driver->ops pointer in the tty as tty->ops - Remove various surplus lock calls we no longer need - Remove proc_write method as noted by Alexey Dobriyan - Introduce some missing sanity checks where certain driver/ldisc combinations would oops as they didn't check needed methods were present [akpm@linux-foundation.org: fix fs/compat_ioctl.c build] [akpm@linux-foundation.org: fix isicom] [akpm@linux-foundation.org: fix arch/ia64/hp/sim/simserial.c build] [akpm@linux-foundation.org: fix kgdb] Signed-off-by:
-
Alan Cox authored
[akpm@linux-foundation.org: fix arm, cleanups] Signed-off-by:
-
Alan Cox authored
- Stop drivers calling their own flush method indirectly, it obfuscates code and it will change soon anyway - A few more lock_kernel paths temporarily needed in some driver internal waiting code - Remove private put_char method that does a write call for one char - we have that anyway - Most but not yet all of the termios copy under lock fixing (some has other dependencies to follow) - Note a few locking bugs in drivers found in the process - Kill remaining [ab]users of TIOCG/SSOFTCAR in the driver, these must go to fix the termios locking Signed-off-by:
-
Alan Cox authored
Again lock the bits we can't trivially prove are safe without the BKL and remove the broken TIOCS/GSOFTCAR handler. Signed-off-by:
-
- 05 Mar, 2008 1 commit
-
-
Julia Lawall authored
In commit e6bafba5 ("wmi: (!x & y) strikes again"), a bug was fixed that involved converting !x & y to !(x & y). The code below shows the same pattern, and thus should perhaps be fixed in the same way. This is not tested and clearly changes the semantics, so it is only something to consider. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/ ) // <smpl> @@ expression E1,E2; @@ ( !E1 & !E2 | - !E1 & E2 + !(E1 & E2) ) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Cc: Jiri Slaby <jirislaby@gmail.com> Signed-off-by:
-
- 18 Oct, 2007 1 commit
-
-
Joe Perches authored
Found these while looking at printk uses. Add missing newlines to dev_<level> uses Add missing KERN_<level> prefixes to multiline dev_<level>s Fixed a wierd->weird spelling typo Added a newline to a printk Signed-off-by:
-
- 17 Jul, 2007 3 commits
-
-
Jiri Slaby authored
irq is int, base is unsigned long Signed-off-by:
-
Jiri Slaby authored
Signed-off-by:
-
Jiri Slaby authored
Don't spin processor when not needed (use sleep instead of delay). Don't release the lock when needed in next iteration -- this actually fixes a bug -- missing braces Signed-off-by:
-
- 08 May, 2007 1 commit
-
-
Jiri Slaby authored
isicom, use pr_debug Signed-off-by:
-
- 11 Feb, 2007 7 commits
-
-
Jiri Slaby authored
tty_wakeup cleanup - remove wake_up_interruptible(&tty->write_wait) surrounding tty_wakup(tty); - substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty); Signed-off-by:
Tilman Schmidt <tilman@imap.cc> Signed-off-by:
-
Jiri Slaby authored
Don't forget to decrease card_count in fail paths and in remove function. Also null board->base in such cases to point out, that this structure is unused and thus can be reassigned. Signed-off-by:
-
Jiri Slaby authored
Add support for higher baud rates (coming from original isi driver). Signed-off-by:
-
Jiri Slaby authored
Check if the card really interrupted us by reading its IO space and eventualy return IRQ_NONE. Signed-off-by:
-
Jiri Slaby authored
isicom, augment card_reset - add 0xee to signatures - change long delays to sleeps - make one sleep shorter not to wait 3s - portcount == 16 is also correct Signed-off-by:
-
Jiri Slaby authored
2 spin_unlocks are omitted in the interrupt handler. Put them there to fix up deadlocking on UP. Signed-off-by:
-
Jiri Slaby authored
- tty_hangup() itself schedules work, so there is no need to schedule hangup in the driver - tty_wakeup(): it's safe to call it while in atomic, so that its schedule_work might be also wiped out Signed-off-by:
-
- 30 Dec, 2006 1 commit
-
-
Jiri Slaby authored
Many spinlock recursion was in the isicom driver. Eliminate it. Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
- 08 Dec, 2006 1 commit
-
-
Jiri Slaby authored
Since tty->index is signed and may be < 0, we should assign this to int not uint. There is already a check to ensure if it is not negative, but gcc complains with -W flag enabled and it is perfectly correct: drivers/char/isicom.c:953: warning: comparison of unsigned expression < 0 is always false Fix this issue by converting `line' variable from uint to int. Signed-off-by:
-
