1. 02 Aug, 2005 4 commits
  2. 01 Aug, 2005 1 commit
  3. 31 Jul, 2005 1 commit
  4. 30 Jul, 2005 3 commits
  5. 29 Jul, 2005 15 commits
  6. 28 Jul, 2005 9 commits
  7. 27 Jul, 2005 7 commits
    • Jesper Juhl's avatar
      [PATCH] clean up inline static vs static inline · 77933d72
      Jesper Juhl authored
      
      
      `gcc -W' likes to complain if the static keyword is not at the beginning of
      the declaration.  This patch fixes all remaining occurrences of "inline
      static" up with "static inline" in the entire kernel tree (140 occurrences in
      47 files).
      
      While making this change I came across a few lines with trailing whitespace
      that I also fixed up, I have also added or removed a blank line or two here
      and there, but there are no functional changes in the patch.
      Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      77933d72
    • Adrian Bunk's avatar
      [PATCH] drivers/media/video/tveeprom.c: possible cleanups · 82ee3e6f
      Adrian Bunk authored
      
      
      This patch contains the following possible cleanups:
      - make two needlessly global structs static
      - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
      Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      82ee3e6f
    • Ralf Baechle's avatar
      [PATCH] serial_core whitespace fix · e5c2d749
      Ralf Baechle authored
      
      
      Use tabs for formatting like anywhere else in this file.
      
      Cc: Russell King <rmk@arm.linux.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      e5c2d749
    • Olaf Hering's avatar
      [PATCH] turn many #if $undefined_string into #ifdef $undefined_string · 44456d37
      Olaf Hering authored
      
      
      turn many #if $undefined_string into #ifdef $undefined_string to fix some
      warnings after -Wno-def was added to global CFLAGS
      Signed-off-by: default avatarOlaf Hering <olh@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      44456d37
    • Andreas Gruenbacher's avatar
      [PATCH] mbcache: Remove unused mb_cache_shrink parameter · 8c52ab42
      Andreas Gruenbacher authored
      
      
      The cache parameter to mb_cache_shrink isn't used.  We may as well remove
      it.
      Signed-off-by: default avatarAndreas Gruenbacher <agruen@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      8c52ab42
    • Peter Staubach's avatar
      [PATCH] stale POSIX lock handling · c293621b
      Peter Staubach authored
      
      
      I believe that there is a problem with the handling of POSIX locks, which
      the attached patch should address.
      
      The problem appears to be a race between fcntl(2) and close(2).  A
      multithreaded application could close a file descriptor at the same time as
      it is trying to acquire a lock using the same file descriptor.  I would
      suggest that that multithreaded application is not providing the proper
      synchronization for itself, but the OS should still behave correctly.
      
      SUS3 (Single UNIX Specification Version 3, read: POSIX) indicates that when
      a file descriptor is closed, that all POSIX locks on the file, owned by the
      process which closed the file descriptor, should be released.
      
      The trick here is when those locks are released.  The current code releases
      all locks which exist when close is processing, but any locks in progress
      are handled when the last reference to the open file is released.
      
      There are three cases to consider.
      
      One is the simple case, a multithreaded (mt) process has a file open and
      races to close it and acquire a lock on it.  In this case, the close will
      release one reference to the open file and when the fcntl is done, it will
      release the other reference.  For this situation, no locks should exist on
      the file when both the close and fcntl operations are done.  The current
      system will handle this case because the last reference to the open file is
      being released.
      
      The second case is when the mt process has dup(2)'d the file descriptor.
      The close will release one reference to the file and the fcntl, when done,
      will release another, but there will still be at least one more reference
      to the open file.  One could argue that the existence of a lock on the file
      after the close has completed is okay, because it was acquired after the
      close operation and there is still a way for the application to release the
      lock on the file, using an existing file descriptor.
      
      The third case is when the mt process has forked, after opening the file
      and either before or after becoming an mt process.  In this case, each
      process would hold a reference to the open file.  For each process, this
      degenerates to first case above.  However, the lock continues to exist
      until both processes have released their references to the open file.  This
      lock could block other lock requests.
      
      The changes to release the lock when the last reference to the open file
      aren't quite right because they would allow the lock to exist as long as
      there was a reference to the open file.  This is too long.
      
      The new proposed solution is to add support in the fcntl code path to
      detect a race with close and then to release the lock which was just
      acquired when such as race is detected.  This causes locks to be released
      in a timely fashion and for the system to conform to the POSIX semantic
      specification.
      
      This was tested by instrumenting a kernel to detect the handling locks and
      then running a program which generates case #3 above.  A dangling lock
      could be reliably generated.  When the changes to detect the close/fcntl
      race were added, a dangling lock could no longer be generated.
      
      Cc: Matthew Wilcox <willy@debian.org>
      Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      c293621b
    • Heiko Carstens's avatar
      [PATCH] s390: atomic64 inline functions · 46ee058c
      Heiko Carstens authored
      
      
      The atomic64 primitives are supposed to have 64-bit parameters instead of int.
      Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      46ee058c