Commit 09bd0840 authored by Bin Meng's avatar Bin Meng Committed by Simon Glass
Browse files

serial: ns16550: Correct the base address type

Currently ns16550_serial_assign_base() treats the argument 'base'
with type `ulong`. This is incorrect because the base address was
obtained from device tree with type `fdt_addr_t` that can represent
a physical address larger than 32-bit in a 32-bit system.

Fixes: 9e6ce621

 ("serial: ns16550: Fix ordering of getting base address")
Signed-off-by: Bin Meng's avatarBin Meng <>
Reviewed-by: Simon Glass's avatarSimon Glass <>
parent ced4c31e
......@@ -483,7 +483,7 @@ static int ns16550_serial_getinfo(struct udevice *dev,
return 0;
static int ns16550_serial_assign_base(struct ns16550_plat *plat, ulong base)
static int ns16550_serial_assign_base(struct ns16550_plat *plat, fdt_addr_t base)
if (base == FDT_ADDR_T_NONE)
return -EINVAL;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment