Commit 0b97faaa authored by Simon Glass's avatar Simon Glass
Browse files

binman: Don't show image-skip message by default

This message is not very important since it is simply indicating that the
user's instructions are being followed. Only show it when the verbosity
level is above the default.

Also drop the unnecessary extra newline on this message, which causes two
line breaks.

Series-changes: 2
- Update commit message to mention dropping the \n
- Update testSelectImage() to test in normal and verbose modes
Signed-off-by: Simon Glass's avatarSimon Glass <>
parent c3da0e24
......@@ -133,8 +133,8 @@ def Binman(options, args):
if name not in options.image:
del images[name]
if skip:
print 'Skipping images: %s\n' % ', '.join(skip)
if skip and options.verbosity >= 2:
print 'Skipping images: %s' % ', '.join(skip)
state.Prepare(images, dtb)
......@@ -187,7 +187,8 @@ class TestFunctional(unittest.TestCase):
return control.Binman(options, args)
def _DoTestFile(self, fname, debug=False, map=False, update_dtb=False,
entry_args=None, images=None, use_real_dtb=False):
entry_args=None, images=None, use_real_dtb=False,
"""Run binman with a given test file
......@@ -210,6 +211,8 @@ class TestFunctional(unittest.TestCase):
if not use_real_dtb:
if verbosity is not None:
args.append('-v%d' % verbosity)
if entry_args:
for arg, value in entry_args.iteritems():
args.append('-a%s=%s' % (arg, value))
......@@ -1459,13 +1462,22 @@ class TestFunctional(unittest.TestCase):
def testSelectImage(self):
"""Test that we can select which images to build"""
with test_util.capture_sys_output() as (stdout, stderr):
retcode = self._DoTestFile('006_dual_image.dts', images=['image2'])
self.assertEqual(0, retcode)
self.assertIn('Skipping images: image1', stdout.getvalue())
expected = 'Skipping images: image1'
# We should only get the expected message in verbose mode
for verbosity in (None, 2):
with test_util.capture_sys_output() as (stdout, stderr):
retcode = self._DoTestFile('006_dual_image.dts',
self.assertEqual(0, retcode)
if verbosity:
self.assertIn(expected, stdout.getvalue())
self.assertNotIn(expected, stdout.getvalue())
def testUpdateFdtAll(self):
"""Test that all device trees are updated with offset/size info"""
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment