Commit 2fe00093 authored by Simon Glass's avatar Simon Glass
Browse files

x86: mrccache: Add more debugging

When the MRC cache fails to save it is useful to have some debugging info
to indicate what when wrong. Add some more debug() calls.

Signed-off-by: Simon Glass's avatarSimon Glass <>
Reviewed-by: Bin Meng's avatarBin Meng <>
parent 290e2387
......@@ -113,8 +113,10 @@ int mrccache_update(struct udevice *sf, struct mrc_region *entry,
ulong base_addr;
int ret;
if (!is_mrc_cache(cur))
if (!is_mrc_cache(cur)) {
debug("%s: Cache data not valid\n", __func__);
return -EINVAL;
/* Find the last used block */
base_addr = entry->base + entry->offset;
......@@ -205,17 +207,23 @@ int mrccache_get_region(struct udevice **devp, struct mrc_region *entry)
return -ENOENT;
if (fdtdec_get_int_array(blob, node, "memory-map", reg, 2))
if (fdtdec_get_int_array(blob, node, "memory-map", reg, 2)) {
debug("%s: Cannot find memory map\n", __func__);
return -EINVAL;
entry->base = reg[0];
/* Find the place where we put the MRC cache */
mrc_node = fdt_subnode_offset(blob, node, "rw-mrc-cache");
if (mrc_node < 0)
if (mrc_node < 0) {
debug("%s: Cannot find node\n", __func__);
return -EPERM;
if (fdtdec_get_int_array(blob, mrc_node, "reg", reg, 2))
if (fdtdec_get_int_array(blob, mrc_node, "reg", reg, 2)) {
debug("%s: Cannot find address\n", __func__);
return -EINVAL;
entry->offset = reg[0];
entry->length = reg[1];
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment