tools: Fix default target compile tools in Python tools

In commit 1e4687aa ("binman: Use target-specific tools when
cross-compiling"), a utility function was implemented to get preferred
compilation tools using environment variables like CC and CROSS_COMPILE.
Although it intended to provide custom default tools (same as those in
the global Makefile) when no relevant variables were set (for example
using "gcc" for "cc"), it is only doing so when CROSS_COMPILE is set and
returning the literal name of the tool otherwise.

Remove the check for an empty CROSS_COMPILE, which makes the function
use it as an empty prefix to the custom defaults and return the intended
executables.

Fixes: 1e4687aa ("binman: Use target-specific tools when cross-compiling")
Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
40 jobs for dm-pull-6jul21 in 75 minutes and 31 seconds (queued for 44 minutes and 42 seconds)
latest
Status Name Job ID Coverage
  Testsuites
passed Build envtools #287554

00:00:15

passed Build tools-only #287553

00:00:14

passed Check for configs without MAINTAINERS entry #287552

00:00:11

passed cppcheck #287548

00:00:23

passed grep TODO/FIXME/HACK #287549

00:00:12

passed htmldocs #287550

00:00:48

passed Run binman, buildman, dtoc, Kconfig and patman testsuites #287555

00:01:26

passed Run tests for Nokia RX-51 (aka N900) #287556

00:03:17

passed sloccount #287551

00:00:38

 
  Test.Py
passed evb-ast2500 test.py #287561

00:00:50

passed integratorcp_cm926ejs test.py #287563

00:01:04

passed qemu_arm64 test.py #287565

00:01:30

passed qemu_arm test.py #287564

00:02:18

passed qemu_malta64el test.py #287569

00:01:09

passed qemu_malta64 test.py #287568

00:00:52

passed qemu_maltael test.py #287567

00:01:05

passed qemu_malta test.py #287566

00:01:06

passed qemu-ppce500 test.py #287570

00:00:51

passed qemu-riscv32_spl test.py #287573

00:00:57

passed qemu-riscv32 test.py #287571

00:01:27

passed qemu-riscv64_spl test.py #287574

00:01:18

passed qemu-riscv64 test.py #287572

00:01:32

passed qemu-x86_64 test.py #287576

00:01:54

passed qemu-x86 test.py #287575

00:01:28

passed r2dplus_i82557c test.py #287577

00:01:06

passed r2dplus_pcnet test.py #287578

00:00:50

passed r2dplus_rtl8139 test.py #287579

00:01:19

passed r2dplus_tulip test.py #287580

00:01:06

passed sandbox_flattree test.py #287562

00:01:15

passed sandbox_noinst_test.py #287560

00:01:41

passed sandbox_spl test.py #287559

00:01:12

passed sandbox test.py #287557

00:07:16

passed sandbox with clang test.py #287558

00:06:21

passed xilinx_versal_virt test.py #287582

00:00:51

passed xilinx_zynq_virt test.py #287581

00:00:54

passed xtfpga test.py #287583

00:01:03

 
  World Build
passed build all 32bit ARM platforms #287584

00:50:54

passed build all 64bit ARM platforms #287585

00:18:37

passed build all other platforms #287587

00:05:43

passed build all PowerPC platforms #287586

00:05:56