Commit 4b756b01 authored by Tom Rini's avatar Tom Rini
Browse files

hash.c: Correct non-hash subcommand crc32 addr-save support

In the case of not having CONFIG_CMD_HASH but having CONFIG_CMD_CRC32
enabled (and not CONFIG_CRC32_VERIFY), we end up in this part of the
code path on hash_command().  However, we will only have exactly 3 args
here, and 3 > 3 is false, and we will not try and store the hash at the
address given as arg #3

.  The next problem however is that we've been
moving argv around so the third value is now in argv[0] not argv[3].

Confirmed on AM335x Beaglebone White.
Signed-off-by: default avatarTom Rini <trini@ti.com>
parent c2e5e802
......@@ -325,8 +325,8 @@ int hash_command(const char *algo_name, int flags, cmd_tbl_t *cmdtp, int flag,
printf("CRC32 for %08lx ... %08lx ==> %08lx\n",
addr, addr + len - 1, crc);
if (argc > 3) {
ptr = (ulong *)simple_strtoul(argv[3], NULL, 16);
if (argc >= 3) {
ptr = (ulong *)simple_strtoul(argv[0], NULL, 16);
*ptr = crc;
}
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment