Commit 3f51a772 authored by Daniel Schwierzeck's avatar Daniel Schwierzeck Committed by Simon Glass
Browse files

sandbox: cros_ec: fix uninitialized use of len



Building with gcc-5.2 raises this warning:

drivers/misc/cros_ec_sandbox.c: In function cros_ec_sandbox_packet:
drivers/misc/cros_ec_sandbox.c:483:5: warning: len may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (len < 0)
     ^

If the function process_cmd() is called with
req_hdr->command == EC_CMD_ENTERING_MODE, the value of len will be
returned uninitialized.
Signed-off-by: Daniel Schwierzeck's avatarDaniel Schwierzeck <daniel.schwierzeck@gmail.com>
Acked-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
parent b6ff6ce6
......@@ -460,6 +460,7 @@ static int process_cmd(struct ec_state *ec,
len = cros_ec_keyscan(ec, resp_data);
break;
case EC_CMD_ENTERING_MODE:
len = 0;
break;
default:
printf(" ** Unknown EC command %#02x\n", req_hdr->command);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment