Commit 676fbd3d authored by Bin Meng's avatar Bin Meng Committed by Priyanka Jain
Browse files

net: phy: Simplify the logic of phy_connect_fixed()



Simplify the logic of phy_connect_fixed() by using the new API
ofnode_phy_is_fixed_link(), which brings additional bonus of
supporting the old DT bindings.
Signed-off-by: Bin Meng's avatarBin Meng <bmeng.cn@gmail.com>
Reviewed-by: Ramon Fried's avatarRamon Fried <rfried.dev@gmail.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Priyanka Jain's avatarPriyanka Jain <priyanka.jain@nxp.com>
parent 188ff18f
......@@ -18,6 +18,7 @@
#include <phy.h>
#include <errno.h>
#include <asm/global_data.h>
#include <dm/of_extra.h>
#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/err.h>
......@@ -1008,15 +1009,14 @@ static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
phy_interface_t interface)
{
ofnode node = dev_ofnode(dev), subnode;
struct phy_device *phydev;
subnode = ofnode_find_subnode(node, "fixed-link");
if (!ofnode_valid(subnode))
return NULL;
struct phy_device *phydev = NULL;
phydev = phy_device_create(bus, 0, PHY_FIXED_ID, false, interface);
if (phydev)
phydev->node = subnode;
if (ofnode_phy_is_fixed_link(node, &subnode)) {
phydev = phy_device_create(bus, 0, PHY_FIXED_ID,
false, interface);
if (phydev)
phydev->node = subnode;
}
return phydev;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment