- Jan 25, 2022
-
-
Simon Glass authored
Allow this to be used on any arch. Also convert to using macros so that we can check the CONFIG option in C code. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
These have sadly found their way to ARM now. Allow any arch to support generating ACPI tables. Disable this for the tools build. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Tom Rini authored
- A number of cleanups to Python code based on running pylint - Integrate changes so that we can run "make pylint" and compare the results to a current baseline. Keep this as a manual check for now. - Improve functionality of moveconfig.py - pci: iproc: Set all 24 bits of PCI class code
-
- Jan 24, 2022
-
-
Tom Rini authored
Rsync all defconfig files using moveconfig.py Signed-off-by:
Tom Rini <trini@konsulko.com>
-
There are over 200 errors in this file. Fix some of them, starting at the beginning of the file. Future work can continue this effort. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
At present there is quite a bit of ad-hoc code reading from files. The most common case is to read the file as lines. Put it in a function and set the unicode encoding correctly. Avoid writing back to a file when there are obviously no changes as this speeds things up slightly. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
At present there is quite a bit of ad-hoc code writing to files. The treatment of newlines is different in some of them. Put it in a function and set the unicode encoding correctly. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Python 2 is not supported anymore and Python 3 has had subprocess.DEVNULL since version 3.3 which was released in 2012. Drop the unnecessary check. Signed-off-by:
Simon Glass <sjg@chromium.org> Reviewed-by:
Heinrich Schuchardt <xypron.glpk@gmx.de>
-
This is a newer library and is now preferred for Python scripts. Update the code to use it instead of optparse Use 'args' instead of 'options' throughout, since this is the term used in that module. Also it helps to avoid confusion with CONFIG options, a term that is used in this file. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Quite a few places use double quotes. Fix this to be consistent with other Python code in U-Boot. Signed-off-by:
Simon Glass <sjg@chromium.org> Reviewed-by:
Heinrich Schuchardt <xypron.glpk@gmx.de>
-
It is useful to be able to find out which boards define a particular option, or combination of options. This is not as easy as grepping the defconfig files since many options are implied by others. Add a -f option to the moveconfig tool to permit this. Update the documentation to cover this, including a better title for the doc page. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Add a -t option to run unit tests in this program. So far, there is none. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Put the options in sorted order by their short name so it is easier to find an option. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Move this code out into a function so it can be used elsewhere. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
This doesn't work anymore, since the Kconfig update. The script has no tests so we did not notice. Fix it. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
* assert does not need parentheses * add module docstring * fix misspelled constant True * limit lines to 100 characters Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
-
At present the Python code in U-Boot is somewhat inconsistent, with some files passing pylint quite cleanly and others not. Add a way to track progress on this clean-up, by checking that no module has got any worse as a result of changes. This can be used with 'make pylint'. Signed-off-by:
Simon Glass <sjg@chromium.org> [trini: Re-generate pylint.base]
-
Add some empty __init__ files for binman, buildman and dtoc so that pylint is able to recognise these as Python modules and produce more useful pylint output. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Update the __init__ file to include recently added files. Add a license header while we are here. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
This produces a pylint error at present. Fix it. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
This is created when checking code coverage of Python tools. Ignore it. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Register 0x43c in its low 24 bits contains PCI class code. Update code to set all 24 bits of PCI class code and not only upper 16 bits of PCI class code. Use standard U-Boot macro (PCI_CLASS_BRIDGE_PCI << 8) for constructing all 24-bits of PCI class for PCI bridge Normal decode. Signed-off-by:
Pali Rohár <pali@kernel.org> Acked-by:
Roman Bacik <roman.bacik@broadcom.com>
-
Tom Rini authored
- Assorted dumpimage/mkimage fixes, allow setting the signature algorithm on the command line with mkimage - Bugfix to the misc uclass, CONFIG_MP / CMD_MP Kconfig logic improved, updated Xen platform MAINTAINERS entry and fixed vexpress_aemv8a_semi booting.
-
Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor commands. Compile cmd/mp.c based on CONFIG_CMD_MP. Signed-off-by:
Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> Signed-off-by:
Michal Simek <michal.simek@xilinx.com>
-
The component st_size of struct stat is of type off_t. Depending on the system printing it using %ld leads to a warning: tools/mkimage.c:438:54: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'off_t' {aka 'long long int'} [-Wformat=] 438 | "%s: Bad size: \"%s\" is not valid image: size %ld < %u\n", | ~~^ | | | long int | %lld When comparing an off_t value to a 32bit integer we should not convert to uint32_t but to off_t which may be wider. Reported-by:
Milan P. Stanić <mps@arvanta.net> Fixes: 331f0800 ("mkimage: allow -l to work on block devices on Linux") Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by:
Mark Kettenis <kettenis@openbsd.org>
-
Changing e-mail because of leaving EPAM. Signed-off-by:
Anastasiia Lukianenko <vicooodin@gmail.com> Reviewed-by:
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
-
This permits to prepare FIT image description that do not hard-code the final choice of the signature algorithm, possibly requiring the user to patch the sources. When -o <algo> is specified, this information is used in favor of the 'algo' property in the signature node. Furthermore, that property is set accordingly when writing the image. Signed-off-by:
Jan Kiszka <jan.kiszka@siemens.com>
-
The actual opt string is inlined - and different. Seems this was a left-over from older versions of 603e26f7. Signed-off-by:
Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Modifications would be invalid. Signed-off-by:
Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
The write operation in misc_ops already takes a "const void *" buffer, but misc_write() takes a mutable "void *". There's no reason for this, so make misc_write() consistent with the standard write() prototype. Signed-off-by:
John Keeping <john@metanate.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
fit_verify_header fails if it detects unit addresses "@". However, this will break tools like dumpimage on fit images which worked with previous versions of the tool (e.g. 2020.04 vs 2021.07). As an example the output of: dumpimage -l <fit image> is: FIT description: U-Boot fitImage for Linux Distribution Created: Thu Jan 1 01:00:00 1970 Image 0 (kernel@1) Description: Linux kernel Created: Thu Jan 1 01:00:00 1970 Type: Kernel Image Compression: gzip compressed Data Size: 6442456 Bytes = 6291.46 KiB = 6.14 MiB Architecture: AArch64 OS: Linux Load Address: 0x80080000 Entry Point: 0x80080000 Hash algo: sha256 Hash value: ... Image 1 (fdt@freescale_fsl-s32g274a-evb.dtb) Description: Flattened Device Tree blob Created: Thu Jan 1 01:00:00 1970 Type: Flat Device Tree Compression: uncompressed Data Size: 39661 Bytes = 38.73 KiB = 0.04 MiB Architecture: AArch64 Hash algo: sha256 Hash value: ... Default Configuration: 'conf@freescale_fsl-s32g274a-evb.dtb' Configuration 0 (conf@freescale_fsl-s32g274a-evb.dtb) Description: 1 Linux kernel, FDT blob Kernel: kernel@1 FDT: fdt@freescale_fsl-s32g274a-evb.dtb Hash algo: sha256 Hash value: unavailable But with newer version it shows: dumpimage -l <fit image> GP Header: Size d00dfeed LoadAddr 62f0a4 This commit will output a warning that unit addresses were detected but will not fail: dumpimage -l <fit image> Image contains unit addresses @, this will break signing ... Signed-off-by:
Stefan Eichenberger <eichest@gmail.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
fit_extract_contents does a fit_check_format even thought it was already checked during imagetool_verify_print_header. Therefore, this check is not necessary. This commit removes the redundancy. Signed-off-by:
Stefan Eichenberger <eichest@gmail.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Commit 270f8710 ("crc32: Add crc32 implementation using __builtin_aarch64_crc32b") enabled the usage of ARMv8 CRC instructions by default, for all arm64 builds. And indeed all Arm Ltd. v8 Cortex-A cores support the instructions, and they are mandatory starting with architecture revision v8.1, so realistically every known hardware implementation should support them. The Arm Fastmodel however defaults to the bare minimum ARMv8 feature set by default, which means v8.0 without the CRC instructions, so U-Boot hangs very early at the moment, without any output (the boot-wrapper or TF-A printing the last visible lines). Support for those instructions can be enabled on the model command line by either: -C cluster0.cpu0.enable_crc32=1 (for each core) or by using a higher architecture revision by default: -C cluster0.has_arm_v8-1=1 (for each cluster) Of course any arch revision higher than v8.1 would work as well. But for the sake of a smooth out-of-the-box experience, let's just disable the usage of those instructions in the defconfig, to avoid random hangs without any clues. Reported-by:
Ross Burton <ross.burton@arm.com> Signed-off-by:
Andre Przywara <andre.przywara@arm.com> Acked-by:
Marek Vasut <marex@denx.de>
-
https://source.denx.de/u-boot/custodians/u-boot-stmTom Rini authored
- stm32mp15: sync DT with kernel v5.16 - stm32mp15: Enable OF_BOARD config flag - DHCOM: sync DT with kernel 5.15.12 - stm32mp: Fix USB boot device - stm32mp: Remove bootcount activation - stm32mp: Fix board_get_alt_info_mmc() - board: stm32mp1: solve compilation issue when ENV_IS_IN_MMC is deactivated - stm32prog: add partition name in treat_partition_list error messages
-
Patrice Chotard authored
Since commit 98550343 ("fdt: Don't call board_fdt_blob_setup() without OF_BOARD") board_fdt_blob_setup() is no more called on STM32MP platforms in trusted boot which hangs during boot process. Enable OF_BOARD flag to fix this issue. Signed-off-by:
Patrice Chotard <patrice.chotard@foss.st.com> Reviewed-by:
Patrick Delaunay <patrick.delaunay@foss.st.com>
-
Add the partition name and remove the line number in error messages of treat_partition_list() to provide correct information to user of STM32CubeProgrammer. The "line number" value was confusing because it is incorrect here; the index in part_array[] is not aligned with the line number in the parsed Layout file, because the empty lines and the lines beginning by '#' are skipped during the first parsing in parse_flash_layout(). Signed-off-by:
Patrick Delaunay <patrick.delaunay@foss.st.com> Reviewed-by:
Patrice Chotard <patrice.chotard@foss.st.com>
-
Solve compilation issue on undefined CONFIG_SYS_MMC_ENV_DEV when CONFIG_ENV_IS_IN_MMC is deactivated on STMicroelectronics boards defconfig Fixes: 9f971936 ("board: stm32mp1: use CONFIG_SYS_MMC_ENV_DEV when available") Signed-off-by:
Patrick Delaunay <patrick.delaunay@foss.st.com> Reviewed-by:
Patrice Chotard <patrice.chotard@foss.st.com>
-
MAX_SEARCH_PARTITIONS is the highest possible partition number. Do not skip the last partition in board_get_alt_info_mmc(). Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by:
Patrice Chotard <patrice.chotard@foss.st.com> Reviewed-by:
Patrick Delaunay <patrick.delaunay@foss.st.com>
-
Synchronize DH DHCOM DTs with Linux commit 25960cafa06e ("Linux 5.15.12"). There is no functional change to the resulting DTs. The eeprom0 alias and PHY reset GPIO are now reinstated in SoM u-boot dtsi. Signed-off-by:
Marek Vasut <marex@denx.de> Cc: Patrice Chotard <patrice.chotard@foss.st.com> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> Reviewed-by:
Patrick Delaunay <patrick.delaunay@foss.st.com>
-
Synchronize DH DHCOR DTs with Linux commit 25960cafa06e ("Linux 5.15.12"). There is no functional change to the resulting DTs. The eeprom0 alias is now reinstated in SoM u-boot dtsi, the PHY reset GPIO is reinstated in AV96 u-boot dtsi. Signed-off-by:
Marek Vasut <marex@denx.de> Cc: Patrice Chotard <patrice.chotard@foss.st.com> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> Reviewed-by:
Patrick Delaunay <patrick.delaunay@foss.st.com>
-