Commit 25805b6f authored by Tero Kristo's avatar Tero Kristo Committed by Lokesh Vutla
Browse files

remoteproc: k3-r5: remove sysfw PM calls if not supported



With the sysfw rearch, sysfw PM calls are no longer available from SPL
level. To properly support this, remove the is_on checks and the reset
assertion from the R5 remoteproc driver as these are not supported.
Attempting to access unavailable services will cause the device to hang.
Signed-off-by: default avatarTero Kristo <t-kristo@ti.com>
Signed-off-by: default avatarTero Kristo <kristo@kernel.org>
parent 99214c1f
......@@ -804,19 +804,27 @@ static int k3_r5f_probe(struct udevice *dev)
return ret;
}
ret = core->tsp.sci->ops.dev_ops.is_on(core->tsp.sci, core->tsp.dev_id,
&r_state, &core->in_use);
if (ret)
return ret;
/*
* The PM functionality is not supported by the firmware during
* SPL execution with the separated DM firmware image. The following
* piece of code is not compiled in that case.
*/
if (!IS_ENABLED(CONFIG_K3_DM_FW)) {
ret = core->tsp.sci->ops.dev_ops.is_on(core->tsp.sci,
core->tsp.dev_id,
&r_state, &core->in_use);
if (ret)
return ret;
if (core->in_use) {
dev_info(dev, "Core %d is already in use. No rproc commands work\n",
core->tsp.proc_id);
return 0;
}
if (core->in_use) {
dev_info(dev, "Core %d is already in use. No rproc commands work\n",
core->tsp.proc_id);
return 0;
}
/* Make sure Local reset is asserted. Redundant? */
reset_assert(&core->reset);
/* Make sure Local reset is asserted. Redundant? */
reset_assert(&core->reset);
}
ret = k3_r5f_rproc_configure(core);
if (ret) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment