1. 04 Jun, 2021 1 commit
    • Pali Rohár's avatar
      arm: a37xx: pci: Don't put link into LTSSM Recovery state during probe · 127dbec3
      Pali Rohár authored and Stefan Roese's avatar Stefan Roese committed
      
      
      During our debugging of the Aardvark driver in Linux we have discovered
      that the PCIE_CORE_LINK_CTRL_STAT_REG register in fact controls standard
      PCIe Link Control Register for PCIe Root Bridge. This led us to discover
      that the name of the PCIE_CORE_LINK_TRAINING macro and the corresponding
      comment by this macro's usage is misleading; this bit in fact controls
      Retrain Link, which, according to PCIe base spec is defined as:
      
        A write of 1b to this bit initiates Link retraining by directing the
        Physical Layer LTSSM to the Recovery state. If the LTSSM is already in
        Recovery or Configuration, re-entering Recovery is permitted but not
        required.
      
      Entering Recovery state is normally done from LTSSM L0, L0s and L1 states.
      But since the pci-aardvark.c driver enables Link Training just a few lines
      above, the controller is not in L0 ready state yet. So setting aardvark bit
      PCIE_CORE_LINK_TRAINING does not actually enter Recovery state at this
      place.
      
      Moreover, trying to enter LTSSM Recovery state without other configuration
      is causing issues for some cards (e.g. Atheros AR9xxx and QCA9xxx). Since
      Recovery state is not entered, these issues are not triggered.
      
      Remove code which tries to enter LTSSM Recovery state completely.
      Signed-off-by: default avatarPali Rohár <pali@kernel.org>
      Reviewed-by: default avatarMarek Behún <marek.behun@nic.cz>
      Reviewed-by: Stefan Roese's avatarStefan Roese <sr@denx.de>
      127dbec3
  2. 01 Jun, 2021 1 commit
  3. 31 May, 2021 11 commits
  4. 30 May, 2021 2 commits
  5. 28 May, 2021 13 commits
  6. 27 May, 2021 8 commits
  7. 26 May, 2021 4 commits
    • Sean Anderson's avatar
      test: Remove duplicate macro · cb6c9c83
      Sean Anderson authored and Tom Rini's avatar Tom Rini committed
      ut_asserteq_strn is defined twice. Remove one definition.
      
      Fixes: 33d7edfd
      
       ("test: Add a way to check part of a console line or skip it")
      Signed-off-by: Sean Anderson's avatarSean Anderson <seanga2@gmail.com>
      Reviewed-by: Heinrich Schuchardt's avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      cb6c9c83
    • Harm Berntsen's avatar
      GitLab: Remove tags for sandbox_noinst tests · b725ed50
      Harm Berntsen authored and Tom Rini's avatar Tom Rini committed
      Commit 712cc962 ("GitLab: Remove "tags" stanzas") removed the 'all'
      tag from all the jobs. The sandbox_noinst_test.py test was added in
      between the author date and commit date (commit 6c914e42
      
      
      ("azure/gitlab: Add tests for sandbox_noinst")) which is probably why it
      still contains the tags. This commit fixes that so all jobs now don't
      require tags on the GitLab runners.
      Signed-off-by: default avatarHarm Berntsen <harm.berntsen@nedap.com>
      CC: Simon Glass <sjg@chromium.org>
      Acked-by: default avatarPratyush Yadav <p.yadav@ti.com>
      b725ed50
    • Alper Nebi Yasak's avatar
      test: Fix filesystem tests always being skipped · 77bfaad0
      Alper Nebi Yasak authored and Tom Rini's avatar Tom Rini committed
      Commit 1ba21bb0 ("test: Don't unmount not (yet) mounted system")
      fixes an issue in the filesystem tests where the test setup may fail
      to mount an image and still attempt to unmount it. However, the commit
      unintentionally breaks the test setups in two ways.
      
      The newly created unmounted filesystem images are being immediately
      deleted due to some cleanup steps being misplaced into finally blocks,
      which makes them always run instead of only on failures. The mount calls
      always fail since the images never exist, causing the tests to be always
      skipped. This patch moves these cleanup calls into the except blocks to
      fix this and makes the tests run again.
      
      There are also unmount calls misplaced into finally blocks, making them
      run after the tests instead of before the tests. These unmount calls
      make the filesystem image file consistent with the changes made to it as
      part of the test setup, and this misplacement is making a number of
      tests fail unexpectedly.
      
      The unmount calls must be run before the tests use the image, meaning
      before the yield call and not in the finally block. They must also be
      run as a cleanup step when the filesystem setup fails, so they can't be
      placed as the final call in the try blocks since they would be skipped
      on such failures. For these reasons, this patch places the unmount calls
      both in the except blocks and the else blocks of the final setup step.
      This makes the unexpectedly failing tests to succeed again.
      
      Furthermore, this isolates the mount calls to their own try-except
      statement to avoid reintroducing the original issue of unmounting a
      not-mounted image while fixing the unmount misplacement.
      
      After these fixes, running "make tests" with guestmount available results
      in two test failures not related to the mentioned commit. If the
      guestmount executables are unavailable, the mounts fallback to using
      sudo and result in no failures.
      
      Fixes: 1ba21bb0
      
       ("test: Don't unmount not (yet) mounted system")
      Signed-off-by: default avatarAlper Nebi Yasak <alpernebiyasak@gmail.com>
      Acked-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
      77bfaad0
    • Michal Simek's avatar
      spl: Kconfig: Use tabs instead of space for alignment · ce869b55
      Michal Simek authored and Tom Rini's avatar Tom Rini committed
      
      
      A lot of entries were using spaces instead of tab for alignment that's why
      it is good to fix it to use the same style everywhere.
      Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
      Reviewed-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
      ce869b55