Skip to content
  • Masahiro Yamada's avatar
    treewide: convert (void *)devfdt_get_addr() to dev_read_addr_ptr() · 8613c8d8
    Masahiro Yamada authored and Simon Glass's avatar Simon Glass committed
    
    
    Use the _ptr suffixed variant instead of casting. Also, convert it to
    dev_read_addr_ptr(), which is safe to CONFIG_OF_LIVE.
    
    One curious part is an error check like follows in
    drivers/watchdog/omap_wdt.c:
    
        priv->regs = (struct wd_timer *)devfdt_get_addr(dev);
        if (!priv->regs)
                return -EINVAL;
    
    devfdt_get_addr() returns FDT_ADDR_T_NONE (i.e. -1) on error.
    So, this code does not catch any error in DT parsing.
    
    dev_read_addr_ptr() returns NULL on error, so this error check
    will work.
    
    I generated this commit by the following command:
    
     $ find . -name .git -prune -o -name '*.[ch]' -type f -print | \
       xargs sed -i -e 's/([^*)]*\*)devfdt_get_addr(/dev_read_addr_ptr(/'
    
    I manually fixed drivers/usb/host/ehci-mx6.c
    
    Signed-off-by: Masahiro Yamada's avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    8613c8d8